Merge pull request #588 from oskarhenriksson/fix_small_nid_bugs

Author: PBrdng

src/numerical_irreducible_decomposition.jl

@@ -1126,15 +1126,15 @@ function n_components(
     else
         out = 0
         for d in dims
-            if haskey(D, k)
-                out += sum(length(last(Ws)) for Ws in D[d])
+            if haskey(D, d)
+                out += length(D[d])
             end
         end
     end
 
     out
 end
-n_components(N::NumericalIrreducibleDecomposition, dim::Int) = n_components(N, [dim])
+n_components(N::NumericalIrreducibleDecomposition, dim::Int) = n_components(N, dims = [dim])
 
 """
 

test/nid_test.jl

@@ -53,6 +53,11 @@
 
         N3 = nid(F; monodromy_options = MonodromyOptions(; trace_test_tol = 1e-12))
         @test isa(N3, NumericalIrreducibleDecomposition)
+
+        # number of components
+        @test n_components(N3) == 4
+        @test n_components(N3, dims = [1, 2]) == 3
+        @test n_components(N3, 1) == 2
     end
 
     @testset "Hypersurface of degree 5" begin