Merge pull request #86 from CarloLucibello/master

DhairyaLGandhi · web-flow · commit efe5c531fce4 · 2021-02-27T16:21:39.000+05:30
fix Dict bug
diff --git a/.gitignore b/.gitignore
@@ -1,3 +1,5 @@
 *.jl.cov
 *.jl.*.cov
 *.jl.mem
+Manifest.toml
+test.bson
diff --git a/src/extensions.jl b/src/extensions.jl
@@ -1,4 +1,5 @@
 lower(x::Dict{Symbol}) = BSONDict(x)
+lower(x::BSONDict) = BSONDict(x)
 
 # Basic Types
 
diff --git a/test.bson b/test.bson
diff --git a/test/runtests.jl b/test/runtests.jl
@@ -1,7 +1,17 @@
 using BSON
 using Test
 
-roundtrip_equal(x) = BSON.roundtrip(x) == x
+function roundtrip_equal(x)
+  y = BSON.roundtrip(x)
+  typeof(y) == typeof(x) && x == y
+end
+
+# avoid hitting bug where
+# Dict{Symbol,T} -> Dict{Symbol,Any}
+function roundtrip_equal(x::Dict{Symbol}) 
+  y = BSON.roundtrip(x)
+  y isa Dict{Symbol} && y == x
+end
 
 mutable struct Foo
   x

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`lower(x::Dict{Symbol}) = BSONDict(x)`
	`2`	`+lower(x::BSONDict) = BSONDict(x)`
`2`	`3`
`3`	`4`	`# Basic Types`
`4`	`5`