Deprecation warning on keywords mem of LBFGS operators

Author: abelsiqueira

Project.toml

@@ -1,6 +1,6 @@
 name = "LinearOperators"
 uuid = "5c8ed15e-5a4c-59e4-a42b-c7e8811fb125"
-version = "1.0.1"
+version = "1.1.0"
 
 [deps]
 FastClosures = "9aa1b823-49e4-5ca5-8b0f-3971ec8bab6a"

src/LinearOperators.jl

@@ -24,4 +24,6 @@ include("TimedOperators.jl")
 # Utilities
 include("utilities.jl")
 
+include("deprecated.jl")
+
 end # module

src/deprecated.jl

@@ -0,0 +1,8 @@
+# Deprecated use of positional argument mem
+@deprecate LBFGSOperator(T :: DataType, n :: Int, mem :: Int; kwargs...) LBFGSOperator(T, n; mem=mem, kwargs...) false
+@deprecate LBFGSOperator(n :: Int, mem :: Int; kwargs...) LBFGSOperator(n; mem=mem, kwargs...) false
+@deprecate InverseLBFGSOperator(T :: DataType, n :: Int, mem :: Int; kwargs...) InverseLBFGSOperator(T, n; mem=mem, kwargs...) false
+@deprecate InverseLBFGSOperator(n :: Int, mem :: Int; kwargs...) InverseLBFGSOperator(n; mem=mem, kwargs...) false
+@deprecate LSR1Operator(T :: DataType, n :: Int, mem :: Int; kwargs...) LSR1Operator(T, n; mem=mem, kwargs...) false
+@deprecate LSR1Operator(n :: Int, mem :: Int; kwargs...) LSR1Operator(n; mem=mem, kwargs...) false
+

test/runtests.jl

@@ -9,3 +9,4 @@ include("test_lbfgs.jl")
 include("test_lsr1.jl")
 include("test_kron.jl")
 include("test_callable.jl")
+include("test_deprecated.jl")

test/test_deprecated.jl

@@ -0,0 +1,15 @@
+function test_deprecated()
+  @testset ExtendedTestSet "Deprecated methods" begin
+    n = 10
+    mem = 3
+    T = Float16
+    @test_deprecated LBFGSOperator(n, mem, scaling=false)
+    @test_deprecated InverseLBFGSOperator(n, mem, scaling=false)
+    @test_deprecated LBFGSOperator(T, n, mem, scaling=false)
+    @test_deprecated InverseLBFGSOperator(T, n, mem, scaling=false)
+    @test_deprecated LSR1Operator(n, mem, scaling=false)
+    @test_deprecated LSR1Operator(T, n, mem, scaling=false)
+  end
+end
+
+test_deprecated()