Fix storage unit comparison in PruneUploads job (#2819)

When we converted the culling of old uploaded files to a scheduled job
in #2749 we accidentally started comparison bytes against gigabytes,
resulting in this pruning step getting skipped when it shouldn't be.

Author: zackgalbreath

app/Jobs/PruneUploads.php

@@ -46,7 +46,7 @@ public function handle(): void
                 WHERE project.id = ?
             ', [$project->id])[0]->s ?? -1);
 
-            if ($total_size / (1024 * 1024 * 1024) > $project->uploadquota) {
+            if ($total_size > $project->uploadquota) {
                 // We're over the limit, so delete references to files from oldest to newest until we're
                 // under the limit.  We're probably not over the limit by very much, so we load in relatively
                 // small chunks to minimize the amount of data being loaded.
@@ -58,7 +58,7 @@ public function handle(): void
                         $uploaded_files_to_check = $uploaded_files_to_check->merge($build->uploadedFiles()->pluck('id'));
                         $build->uploadedFiles()->detach();
 
-                        if ($total_size / (1024 * 1024 * 1024) <= $project->uploadquota) {
+                        if ($total_size <= $project->uploadquota) {
                             // Stop the build chunking.
                             return false;
                         }

app/Models/Project.php

@@ -41,7 +41,7 @@
  * @property int $displaylabels
  * @property int $autoremovetimeframe
  * @property int $autoremovemaxbuilds
- * @property int $uploadquota Maximum sum of uploaded file sizes in GiB
+ * @property int $uploadquota Maximum sum of uploaded file sizes (in bytes)
  * @property int $showcoveragecode
  * @property int $sharelabelfilters
  * @property int $authenticatesubmissions

tests/Feature/Jobs/PruneUploadsTest.php

@@ -56,7 +56,7 @@ public function testProjectNoUploadedFiles(): void
 
     public function testUploadedFilesBelowLimit(): void
     {
-        $this->project->uploadquota = 2;
+        $this->project->uploadquota = 2147483648;
         $this->project->save();
 
         $hash = sha1_file(__FILE__);
@@ -94,7 +94,7 @@ public function testUploadedFilesBelowLimit(): void
 
     public function testUploadedFilesAboveLimit(): void
     {
-        $this->project->uploadquota = 1;
+        $this->project->uploadquota = 1073741824;
         $this->project->save();
 
         $hash = sha1_file(__FILE__);