Merge branch 'master' of github.com:SberMarket-Tech/sbmt-outbox

Author: bibendi

README.md

@@ -43,7 +43,7 @@ rails g outbox:install
 
 ### Outbox/inbox items creation
 
-An ActiveRecord model can be generated for the outbox/ inbox item like this:
+An ActiveRecord model can be generated for the outbox/inbox item like this:
 
 ```shell
 rails g outbox:item MaybeNamespaced::SomeOutboxItem --kind outbox
@@ -132,7 +132,7 @@ Example of a Grafana dashboard that you can import [from a file](./examples/graf
 
 ### `Outboxfile`
 
-First of all you shoudl create an `Outboxfile` at the root of your application with the following code:
+First of all you should create an `Outboxfile` at the root of your application with the following code:
 
 ```ruby
 # frozen_string_literal: true
@@ -168,8 +168,8 @@ Rails.application.config.outbox.tap do |config|
     pc.retryable_items_batch_size = 100
 
     # poll tactic: default is optimal for most cases: rate limit + redis job-queue size threshold
-    # poll tactic: aggressive is for high-intencity data: without rate limits + redis job-queue size threshold
-    # poll tactic: low-priority is for low-intencity data: rate limits + redis job-queue size threshold + + redis job-queue lag threshold
+    # poll tactic: aggressive is for high-intensity data: without rate limits + redis job-queue size threshold
+    # poll tactic: low-priority is for low-intensity data: rate limits + redis job-queue size threshold + + redis job-queue lag threshold
     pc.tactic = "default"
     # number of batches that one thread will process per rate interval
     pc.rate_limit = 60
@@ -290,7 +290,7 @@ production:
   bucket_size: 256
 ```
 __CAUTION__:
-- ⚠️ If this option is enabled and an error occurs while processing a message in a bucket, 
+- ⚠️ If this option is enabled and an error occurs while processing a message in a bucket,
 subsequent messages in that bucket won't be processed until the current message is either skipped or successfully processed
 - ⚠️ Cannot use `retry_strategies` and the `strict_order` option at the same time
 

app/interactors/sbmt/outbox/process_item.rb

@@ -93,7 +93,7 @@ def check_retry_strategy(item, retry_strategy)
           track_discarded(item)
           Failure(:discard_item)
         else
-          track_failed("retry stratagy returned unknown failure: #{result.failure}")
+          track_failed("retry strategy returned unknown failure: #{result.failure}")
           Failure(:retry_strategy_failure)
         end
       end

spec/interactors/sbmt/outbox/process_item_spec.rb

@@ -170,7 +170,7 @@
       context "when retry process" do
         let!(:outbox_item) { create(:outbox_item, processed_at: Time.current) }
 
-        it "do not track process_latency" do
+        it "doesn't track process_latency" do
           expect { result }.not_to measure_yabeda_histogram(Yabeda.outbox.process_latency)
         end
       end
@@ -288,7 +288,7 @@
         expect(dummy_middleware).to have_received(:call).with(outbox_item)
       end
 
-      it "increment errors count" do
+      it "increments errors count" do
         expect { result }.to change { outbox_item.reload.errors_count }.from(0).to(1)
       end
 
@@ -316,7 +316,7 @@
           create(:outbox_item, processed_at: 1.hour.ago)
         end
 
-        it "increment errors count" do
+        it "increments errors count" do
           expect { result }.to change { outbox_item.reload.errors_count }.from(0).to(1)
         end
 

spec/jobs/sbmt/outbox/base_delete_stale_items_job_spec.rb

@@ -25,7 +25,7 @@ def item_classes
       .to change(OutboxItem, :count).by(-1)
   end
 
-  context "when item is too yang" do
+  context "when item is too young" do
     let(:created_at) { 1.hour.ago }
 
     it "doesn't delete item" do

spec/lib/sbmt/outbox/v2/poll_throttler/composite_spec.rb

@@ -45,19 +45,19 @@
       allow(throttle_throttler).to receive(:call).and_return(Dry::Monads::Result::Success.new(Sbmt::Outbox::V2::Throttler::THROTTLE_STATUS))
     end
 
-    it "return skip if present" do
+    it "returns skip if present" do
       expect(described_class.new(throttlers: [
         throttle_throttler, noop_throttler, skip_throttler, failure_throttler
       ]).call(0, task, nil).value!).to eq(Sbmt::Outbox::V2::Throttler::SKIP_STATUS)
     end
 
-    it "return failure if present" do
+    it "returns failure if present" do
       expect(described_class.new(throttlers: [
         throttle_throttler, noop_throttler, failure_throttler
       ]).call(0, task, nil).failure).to eq("some err")
     end
 
-    it "return throttle if present" do
+    it "returns throttle if present" do
       expect(described_class.new(throttlers: [
         throttle_throttler, noop_throttler
       ]).call(0, task, nil).value!).to eq(Sbmt::Outbox::V2::Throttler::THROTTLE_STATUS)