Skip to content

Commit c1a395c

Browse files
committed
Update to mac wheels build.
1 parent 8102821 commit c1a395c

File tree

1 file changed

+23
-28
lines changed

1 file changed

+23
-28
lines changed

.github/workflows/build_wheels.yml

Lines changed: 23 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
name: Build wheels
22

3-
on: [push, pull_request]
4-
5-
# Cannot use cibuildwheels because the current images used by cibuildwheels do not support C++17.
3+
on: [push, pull_request]
64

75
jobs:
86
build_wheels_windows:
@@ -11,21 +9,17 @@ jobs:
119
env:
1210
TEMP: C:\Temp
1311
TMP: C:\Temp
14-
12+
1513
strategy:
1614
matrix:
1715
os: [windows-2022]
1816
arch: [x86, x64]
1917
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"]
2018

21-
steps:
19+
steps:
2220
- name: Support longpaths
2321
run: git config --system core.longpaths true
24-
25-
- name: Check LongPathsEnabled
26-
run: |
27-
(Get-ItemProperty "HKLM:System\CurrentControlSet\Control\FileSystem").LongPathsEnabled
28-
22+
2923
- name: Checkout repository
3024
uses: actions/checkout@v4
3125

@@ -45,19 +39,16 @@ jobs:
4539
- name: upload wheels
4640
uses: actions/upload-artifact@v4
4741
with:
48-
name: wheels-windows-${{ matrix.python-version }}-${{ matrix.arch }}
42+
name: wheels-windows-${{ matrix.python-version }}-${{ matrix.arch }}-${{ github.run_id }}
4943
path: ./dist/*.whl
50-
44+
5145
build_wheels_mac:
5246
name: ${{ matrix.os }} ${{ matrix.python-version }} wheels
5347
runs-on: ${{ matrix.os }}
5448
strategy:
5549
matrix:
56-
# Trying to use cibuildwheels to build mac wheels fails because the version of XCode is not high enough.
57-
# There is documentation here https://github.com/pypa/cibuildwheel/blob/main/docs/cpp_standards.md on how to
58-
# set it but I could not get it to work while using the standard images provided by github actions does work.
5950
os: [macos-latest, macos-13]
60-
python-version: [3.9, "3.10", "3.11", "3.12", "3.13"]
51+
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"]
6152
env:
6253
SYSTEM_VERSION_COMPAT: 0
6354

@@ -80,16 +71,16 @@ jobs:
8071
- name: upload wheels
8172
uses: actions/upload-artifact@v4
8273
with:
83-
name: wheels-macos-${{ matrix.python-version }}
74+
name: wheels-macos-${{ matrix.python-version }}-${{ github.run_id }}
8475
path: ./dist/*.whl
85-
76+
8677
build_wheels_manylinux_x86_64:
87-
name: Build manylinux wheels
78+
name: Build manylinux wheels (x86_64)
8879
runs-on: ubuntu-24.04
8980
steps:
9081
- name: Checkout repository
9182
uses: actions/checkout@v4
92-
83+
9384
- name: Install cibuildwheel
9485
run: |
9586
python -m pip install --upgrade pip
@@ -100,17 +91,18 @@ jobs:
10091
CIBW_PLATFORM: "linux"
10192
CIBW_SKIP: "cp36-* cp37-* cp38-*"
10293
CIBW_ARCHS_LINUX: "x86_64"
94+
CIBW_MANYLINUX_X86_64_IMAGE: "quay.io/pypa/manylinux_2_28_x86_64"
10395
run: |
104-
cibuildwheel --output-dir wheelhouse
105-
96+
cibuildwheel --output-dir wheelhouse --verbose
97+
10698
- name: upload wheels
10799
uses: actions/upload-artifact@v4
108100
with:
109-
name: wheels-linux-x86_64
101+
name: wheels-linux-x86_64-${{ github.run_id }}
110102
path: wheelhouse/*.whl
111-
103+
112104
build_wheels_manylinux_arm64:
113-
name: Build manylinux wheels ${{ matrix.python-version }} (arm64)
105+
name: Build manylinux wheels (ARM64)
114106
runs-on: ubuntu-24.04
115107
strategy:
116108
matrix:
@@ -135,11 +127,14 @@ jobs:
135127
CIBW_PLATFORM: "linux"
136128
CIBW_BUILD: ${{ matrix.python-version }}
137129
CIBW_ARCHS_LINUX: "aarch64"
130+
CIBW_MANYLINUX_AARCH64_IMAGE: "quay.io/pypa/manylinux_2_28_aarch64"
131+
CIBW_ENVIRONMENT: "CXXFLAGS='-g -O2 -fno-omit-frame-pointer'"
132+
CIBW_BEFORE_BUILD: "echo 'Running Debug Mode' && pip install debugpy"
138133
run: |
139-
cibuildwheel --output-dir wheelhouse
140-
134+
cibuildwheel --output-dir wheelhouse --verbose
135+
141136
- name: upload wheels
142137
uses: actions/upload-artifact@v4
143138
with:
144-
name: wheels-linux-arm64-${{ matrix.python-version }}
139+
name: wheels-linux-arm64-${{ matrix.python-version }}-${{ github.run_id }}
145140
path: wheelhouse/*.whl

0 commit comments

Comments
 (0)