Linting

Author: bleonheart

gamemode/core/libraries/keybind.lua

@@ -203,13 +203,11 @@ hook.Add("PlayerButtonDown", "liaKeybindPress", function(p, b)
         local data = lia.keybind.stored[action]
         if not data.shouldRun or data.shouldRun(p) then
             if data.serverOnly then
-                -- Server-side execution - network the call
                 net.Start("liaKeybindServer")
                 net.WriteString(action)
                 net.WriteEntity(p)
                 net.SendToServer()
             else
-                -- Client-side execution
                 data.callback(p)
             end
         end
@@ -223,13 +221,11 @@ hook.Add("PlayerButtonUp", "liaKeybindRelease", function(p, b)
         local data = lia.keybind.stored[action]
         if not data.shouldRun or data.shouldRun(p) then
             if data.serverOnly then
-                -- Server-side execution - network the release call
                 net.Start("liaKeybindServer")
                 net.WriteString(action .. "_release")
                 net.WriteEntity(p)
                 net.SendToServer()
             else
-                -- Client-side execution
                 data.release(p)
             end
         end
@@ -383,13 +379,12 @@ lia.keybind.add(KEY_NONE, "adminMode", {
         if client:isStaffOnDuty() then
             local oldCharID = client:getNetVar("OldCharID", 0)
             if oldCharID > 0 then
-                -- Restore original position when switching back to non-staff character
                 local originalPos = client:getNetVar("OriginalPosition")
                 if originalPos then
                     client:SetPos(originalPos)
                     client:setNetVar("OriginalPosition", nil)
                 end
-                
+
                 net.Start("AdminModeSwapCharacter")
                 net.WriteInt(oldCharID, 32)
                 net.Send(client)
@@ -399,12 +394,8 @@ lia.keybind.add(KEY_NONE, "adminMode", {
                 client:notifyLocalized("noPrevChar")
             end
         else
-            -- Save original position when switching to staff mode
             local currentChar = client:getChar()
-            if currentChar and currentChar:getFaction() ~= "staff" then
-                client:setNetVar("OriginalPosition", client:GetPos())
-            end
-            
+            if currentChar and currentChar:getFaction() ~= "staff" then client:setNetVar("OriginalPosition", client:GetPos()) end
             lia.db.query(string.format("SELECT * FROM lia_characters WHERE steamID = \"%s\"", lia.db.escape(steamID)), function(data)
                 for _, row in ipairs(data) do
                     local id = tonumber(row.id)

gamemode/core/netcalls/server.lua

@@ -25,30 +25,20 @@ net.Receive("liaKeybindServer", function(len, ply)
     if not IsValid(ply) then return end
     local action = net.ReadString()
     local player = net.ReadEntity()
-    -- Verify the player is valid and the action exists
     if not IsValid(player) or player ~= ply then return end
     if not lia.keybind.stored[action] then return end
     local data = lia.keybind.stored[action]
-    -- Check if this is a release action
     local isRelease = action:find("_release$")
     local baseAction = action:gsub("_release$", "")
     if isRelease then
-        -- Handle release action
         if data.release and data.serverOnly then
             local success, err = pcall(data.release, player)
-            if not success then
-                -- Log error on server
-                print("Keybind release error for " .. tostring(player) .. ": " .. tostring(err))
-            end
+            if not success then print("Keybind release error for " .. tostring(player) .. ": " .. tostring(err)) end
         end
     else
-        -- Handle press action
         if data.callback and data.serverOnly then
             local success, err = pcall(data.callback, player)
-            if not success then
-                -- Log error on server
-                print("Keybind press error for " .. tostring(player) .. ": " .. tostring(err))
-            end
+            if not success then print("Keybind press error for " .. tostring(player) .. ": " .. tostring(err)) end
         end
     end
 end)

gamemode/init.lua

@@ -1,4 +1,3 @@
-local networkStrings = {"liaKeybindServer", "AdminModeSwapCharacter", "AnimationStatus", "ArgumentsRequest", "BinaryQuestionRequest", "ButtonRequest", "ChangeAttribute", "CharacterInfo", "CheckHack", "CheckSeed", "CurTime-Sync", "CurTimeSync", "DisplayCharList", "ForceUpdateF1", "KickCharacter", "LIA_BigTable_Ack", "NetStreamDS", "OpenInvMenu", "OptionsRequest", "RegenChat", "RequestDropdown", "RequestFactionRoster", "RequestRemoveWarning", "RunAction", "RunOption", "SendTableUI", "ServerChatAddText", "SpawnMenuGiveItem", "SpawnMenuSpawnItem", "StringRequest", "TicketSystem", "TicketSystemClaim", "TicketSystemClose", "TransferMoneyFromP2P", "VendorAllowClass", "VendorAllowFaction", "VendorEdit", "VendorExit", "VendorFaction", "VendorMaxStock", "VendorMode", "VendorMoney", "VendorOpen", "VendorPrice", "VendorStock", "VendorSync", "VendorTrade", "VerifyCheats", "VerifyCheatsResponse", "ViewClaims", "WorkshopDownloader_Info", "WorkshopDownloader_Request", "WorkshopDownloader_Start", "actBar", "attrib", "blindFade", "blindTarget", "cMsg", "cfgList", "cfgSet", "charInfo", "charKick", "charSet", "charVar", "classUpdate", "cmd", "doorMenu", "doorPerm", "gVar", "invAct", "invData", "invQuantity", "item", "liaActiveTickets", "liaAllFlags", "liaAllPKs", "liaAllPlayers", "liaAllWarnings", "liaCharChoose", "liaCharCreate", "liaCharDelete", "liaCharFetchNames", "liaCharList", "liaCharRequest", "liaCharacterData", "liaCharacterInvList", "liaCmdArgPrompt", "liaDBTableData", "liaDBTables", "liaData", "liaDataSync", "liaDatabaseViewData", "liaFactionRosterData", "liaFullCharList", "liaGroupPermChanged", "liaGroupsAdd", "liaGroupsRemove", "liaGroupsRename", "liaGroupsRequest", "liaGroupsSetPerm", "liaInventoryAdd", "liaInventoryData", "liaInventoryDelete", "liaInventoryInit", "liaInventoryRemove", "liaItemDelete", "liaItemInspect", "liaItemInstance", "liaModifyFlags", "liaNotify", "liaNotifyL", "liaPACPartAdd", "liaPACPartRemove", "liaPACPartReset", "liaPACSync", "liaPKsCount", "liaPlayerCharacters", "liaRequestActiveTickets", "liaRequestAllFlags", "liaRequestAllPKs", "liaRequestAllWarnings", "liaRequestDatabaseView", "liaRequestFactionRoster", "liaRequestFullCharList", "liaRequestPKsCount", "liaRequestPlayerCharacters", "liaRequestPlayers", "liaRequestStaffSummary", "liaRequestTableData", "liaRequestTicketsCount", "liaRequestWarningsCount", "liaStaffDiscordPrompt", "liaStaffDiscordResponse", "liaStaffSummary", "liaStorageExit", "liaStorageOpen", "liaStorageTransfer", "liaStorageUnlock", "liaTicketsCount", "liaTransferItem", "liaRestoreOverflowItems", "liaWarningsCount", "lia_managesitrooms_action", "managesitrooms", "msg", "nDel", "nLcl", "nVar", "playerLoadedChar", "postPlayerLoadedChar", "prePlayerLoadedChar", "removeF1", "request_respawn", "rgnDone", "send_logs", "send_logs_request", "seqSet", "setWaypoint", "setWaypointWithLogo", "trunkInitStorage", "updateAdminGroups", "updateAdminPrivileges", "liaProvideServerPassword"}
 DeriveGamemode("sandbox")
 AddCSLuaFile("cl_init.lua")
 AddCSLuaFile("shared.lua")