Debug EffectFactory.CreateMany when there is no separator

Author: Lounek09

Cyberia.Api/Factories/CriterionFactory.cs

@@ -166,13 +166,13 @@ public static ICriterion Create(ReadOnlySpan<char> compressedCriterion)
             return Create(id, @operator);
         }
 
-        var parametersCount = compressedCriterion.Count(separator) + 1;
-        if (parametersCount == 1)
+        var parameterCount = compressedCriterion.Count(separator) + 1;
+        if (parameterCount == 1)
         {
             return Create(id, @operator, compressedCriterion.ToString());
         }
 
-        Span<string> parameters = new string[parametersCount];
+        Span<string> parameters = new string[parameterCount];
         var index = 0;
         foreach (var range in compressedCriterion.Split(separator))
         {

Cyberia.Api/Factories/EffectFactory.cs

@@ -478,7 +478,7 @@ public static IEffect Create(ReadOnlySpan<char> compressedEffect)
 
         if (compressedEffect.IsEmpty)
         {
-            Log.Error("Failed to create Effect from an empty string");
+            Log.Error("Failed to create Effect from empty string");
 
             return new ErroredEffect(string.Empty);
         }
@@ -509,28 +509,28 @@ public static List<IEffect> CreateMany(ReadOnlySpan<char> compressedEffects)
 
         if (compressedEffects.IsEmpty)
         {
+            Log.Error("Failed to create Effects from empty string");
+
             return [];
         }
 
-        var effectCount = compressedEffects.Count(separator) + 1;
-        List<IEffect> effects = new(effectCount);
+        var separatorCount = compressedEffects.Count(separator) + 1;
+        Span<Range> ranges = stackalloc Range[separatorCount];
 
-        var indexOfSeparator = compressedEffects.IndexOf(separator);
-        while (indexOfSeparator != -1)
+        var effectCount = compressedEffects.Split(ranges, separator, StringSplitOptions.RemoveEmptyEntries);
+        if (effectCount == 0)
         {
-            if (indexOfSeparator == 0)
-            {
-                compressedEffects = compressedEffects[1..];
-                indexOfSeparator = compressedEffects.IndexOf(separator);
+            Log.Error("Failed to create Effects from {CompressedEffects}", compressedEffects.ToString());
 
-                continue;
-            }
+            return [];
+        }
 
-            var effect = Create(compressedEffects[..indexOfSeparator]);
-            effects.Add(effect);
+        List<IEffect> effects = new(effectCount);
 
-            compressedEffects = compressedEffects[(indexOfSeparator + 1)..];
-            indexOfSeparator = compressedEffects.IndexOf(separator);
+        for (var i = 0; i < effectCount; i++)
+        {
+            var compressedEffect = compressedEffects[ranges[i]];
+            effects.Add(Create(compressedEffect));
         }
 
         return effects;

Cyberia.Api/JsonConverters/EffectReadOnlyListConverter.cs

@@ -1,6 +1,7 @@
 using Cyberia.Api.Factories;
 using Cyberia.Api.Factories.Effects;
 
+using System.Collections.ObjectModel;
 using System.Text.Json;
 using System.Text.Json.Serialization;
 
@@ -23,7 +24,13 @@ public override IReadOnlyList<IEffect> Read(ref Utf8JsonReader reader, Type type
             throw new JsonException($"Expected {JsonTokenType.String} but got {reader.TokenType}.");
         }
 
-        return EffectFactory.CreateMany(reader.GetString() ?? string.Empty).AsReadOnly();
+        var compressedEffects = reader.GetString();
+        if (string.IsNullOrEmpty(compressedEffects))
+        {
+            return ReadOnlyCollection<IEffect>.Empty;
+        }
+
+        return EffectFactory.CreateMany(compressedEffects).AsReadOnly();
     }
 
     public override void Write(Utf8JsonWriter writer, IReadOnlyList<IEffect> values, JsonSerializerOptions options)

Cyberia.Api/Utils/RuneCalculator.cs

@@ -89,8 +89,8 @@ public static double GetPercentChanceToObtainRune(RuneData runeData, RuneType ty
     public static RuneBundle GetRuneBundleFromStat(RuneData runeData, int itemLevel, int statAmount, double? multiplicator = null)
     {
         RuneBundle bundle = new(runeData, 0, 0, 0, 0);
-        var actualMultiplier = multiplicator ?? GetRandomMultiplicator();
-        var amountExtractable = statAmount * GetPercentStatExtractable(runeData, itemLevel, statAmount) * actualMultiplier / 100;
+        var actualMultiplicator = multiplicator ?? GetRandomMultiplicator();
+        var amountExtractable = statAmount * GetPercentStatExtractable(runeData, itemLevel, statAmount) * actualMultiplicator / 100;
 
         if (runeData.RaRuneItemId is not null)
         {

Cyberia.Salamandra/EventHandlers/InteractionsEventHandler.cs

@@ -153,8 +153,8 @@ private static bool TryParsePacket(
 
         if (!packet.IsEmpty)
         {
-            var parameterSize = packet.Count(PacketFormatter.Separator) + 1;
-            parameters = new string[parameterSize];
+            var parameterCount = packet.Count(PacketFormatter.Separator) + 1;
+            parameters = new string[parameterCount];
 
             var index = 0;
             foreach (var range in packet.Split(PacketFormatter.Separator))