Update the parsing of effects 2154

Author: Lounek09

Cyberia.Api/Data/Items/ItemData.cs

@@ -178,9 +178,8 @@ public bool Tradeable()
         var hasEffectPreventingTrade = GetItemStatsData()?.Effects.Any(x =>
             (x is MarkNotTradableEffect markNotTradableEffect && markNotTradableEffect.IsInfinite()) ||
             (x is MarkNotTradableStrongEffect markNotTradableStrongEffect && markNotTradableStrongEffect.IsInfinite()) ||
-            x is LockToAccountEffect ||
-            (x is LockToAccountUntilEffect lockToAccountUntilEffect && lockToAccountUntilEffect.DateTime > DateTime.Now) ||
-            x is ItemUnbreakableEffect) ?? false;
+            (x is LockToAccountUntilEffect lockToAccountUntilEffect && lockToAccountUntilEffect.IsInfinite()) ||
+            x is LockToAccountEffect || x is ItemUnbreakableEffect) ?? false;
 
         return !IsQuestItem() && !Cursed && !hasEffectPreventingTrade;
     }

Cyberia.Api/Factories/Effects/Elements/LockToAccountUntilEffect.cs

@@ -8,21 +8,31 @@ namespace Cyberia.Api.Factories.Effects.Elements;
 
 public sealed record LockToAccountUntilEffect : Effect
 {
-    public DateTime DateTime { get; init; }
+    public DateTime Until { get; init; }
 
-    private LockToAccountUntilEffect(int id, int duration, int probability, CriteriaReadOnlyCollection criteria, bool dispellable, EffectArea effectArea, DateTime dateTime)
+    private LockToAccountUntilEffect(int id, int duration, int probability, CriteriaReadOnlyCollection criteria, bool dispellable, EffectArea effectArea, DateTime until)
         : base(id, duration, probability, criteria, dispellable, effectArea)
     {
-        DateTime = dateTime;
+        Until = until;
     }
 
     internal static LockToAccountUntilEffect Create(int effectId, EffectParameters parameters, int duration, int probability, CriteriaReadOnlyCollection criteria, bool dispellable, EffectArea effectArea)
     {
         return new(effectId, duration, probability, criteria, dispellable, effectArea, GameDateFormatter.CreateDateTimeFromEffectParameters(parameters));
     }
 
+    public bool IsInfinite()
+    {
+        return Until == DateTime.MaxValue;
+    }
+
     public override DescriptionString GetDescription(CultureInfo? culture = null)
     {
-        return GetDescription(culture, DateTime.ToShortRolePlayString(culture));
+        if (IsInfinite())
+        {
+            return GetDescription(culture, string.Empty);
+        }
+
+        return GetDescription(culture, Until.ToShortRolePlayString(culture));
     }
 }

Cyberia.Api/api/custom/effects.json

@@ -426,7 +426,7 @@
     },
     {
       "id": 2154,
-      "d": "Verrouillé au compte jusqu'au : #1",
+      "d": "Verrouillé au compte #1",
       "p": -100,
       "o": "/",
       "t": true