Skip to content

Commit 143b62a

Browse files
committed
perf: prepend all test calls with command -p
Prepending POSIX-guaranteed utilities with `command -p` instead of just `command` or with nothing at all is more dependable and provides better replicability by avoiding potentially hazardous calls to less secure aliases or symbolic links. Fix #45; see also #41. Signed-off-by: Lucas Larson <LucasLarson@riseup.net>
1 parent 6cbd77d commit 143b62a

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

update

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
#!/usr/bin/env sh
2-
update='2024-01-14'
2+
update='2024-01-15'
33
IFS="$(command -p -- printf -- ' \t\n|')" && IFS="${IFS%'|'}"
44
command -p -- printf -- '\n\n .___ __\n __ ________ __\174 _\057____ _\057 \174_ ____\n\174 \174 \134____ \134 \057 __ \174\134__ \134\134 __\134\057 __ \134\n\174 \174 \057 \174_\076 \076 \057_\057 \174 \057 __ \134\174 \174 \134 ___\057\n\174____\057\174 __\057\134____ \174\050____ \057__\174 \134___ \076\n \174__\174 \134\057 \134\057 \134\057\n a Lucas Larson production\n\n' >&2 && command -p -- sleep 1
55
command -p -- printf -- '\360\237\223\241 verifying network connectivity' >&2
66
command -p -- sleep 1
77
i='0'
8-
while test "${i-}" -lt "$(command -p -- getconf -- CHAR_MAX)"; do
9-
if test "$((i / 3 % 2))" -eq '0'; then command -p -- printf -- '.' >&2; else command -p -- printf -- '\b' >&2; fi
8+
while command -p -- test "${i-}" -lt "$(command -p -- getconf -- CHAR_MAX)"; do
9+
if command -p -- test "$((i / 3 % 2))" -eq '0'; then command -p -- printf -- '.' >&2; else command -p -- printf -- '\b' >&2; fi
1010
i="$((i + 1))"
1111
done
1212
i=''
@@ -71,10 +71,10 @@ if command -v -- rustup >/dev/null 2>&1; then command rustup --verbose update; e
7171
command -p -- printf -- 'checking for npm installation...\n' >&2
7272
if command -v -- npm >/dev/null 2>&1; then
7373
command -p -- printf -- '...and whether this device is can update npm quickly...\n' >&2
74-
if test "$(command -p -- getconf -- LONG_BIT)" -gt 32; then
75-
while test "$(command -p -- find -- "$(command npm config --location=global get prefix)" -name '.DS_Store' -type f -print)" != ''; do command -p -- find -- "$(command npm config --location=global get prefix)" -name '.DS_Store' -type f -delete; done
74+
if command -p -- test "$(command -p -- getconf -- LONG_BIT)" -gt 32; then
75+
while command -p -- test "$(command -p -- find -- "$(command npm config --location=global get prefix)" -name '.DS_Store' -type f -print)" != ''; do command -p -- find -- "$(command npm config --location=global get prefix)" -name '.DS_Store' -type f -delete; done
7676
command npm install --location=global --loglevel=verbose --no-fund -- npm
77-
while test "$(command -p -- find -- "$(command npm config --location=global get prefix)" -name '.DS_Store' -type f -print)" != ''; do command -p -- find -- "$(command npm config --location=global get prefix)" -name '.DS_Store' -type f -delete; done
77+
while command -p -- test "$(command -p -- find -- "$(command npm config --location=global get prefix)" -name '.DS_Store' -type f -print)" != ''; do command -p -- find -- "$(command npm config --location=global get prefix)" -name '.DS_Store' -type f -delete; done
7878
command npm update --location=global --loglevel=verbose --no-fund
7979
else
8080
command -p -- printf -- 'skipping npm update...\n\n' >&2

0 commit comments

Comments
 (0)