Skip to content

Commit 77c60f3

Browse files
committed
refactor: don't build and download H5P artifacts on install
1 parent dc5a0c2 commit 77c60f3

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

.circleci/config.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ jobs:
1515
- restore_cache:
1616
key: h5p-core-cache2-{{ checksum "scripts/install.sh" }}
1717
- run: npm ci
18+
- run: npm run setup
1819
- restore_cache:
1920
key: h5p-examples-cache-{{ checksum "test/data/content-type-cache/real-content-types.json" }}
2021
- run: |

docs/development/getting-started.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ windows) as a command shell (otherwise scripts won't run).
1616
git clone https://github.com/lumieducation/h5p-nodejs-library
1717
cd h5p-nodejs-library
1818
npm install
19+
npm run setup
1920
```
2021

2122
This will install all dependencies in all packages, linking all

package.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
"build:h5p-svg-sanitizer": "npm run build --workspace=packages/h5p-svg-sanitizer",
2020
"build:h5p-webcomponents": "npm run build --workspace=packages/h5p-webcomponents",
2121
"build": "npm run build --workspace=packages/h5p-server && concurrently \"npm run build --workspace=packages/h5p-express\" \"npm run build --workspace=packages/h5p-html-exporter\" \"npm run build --workspace=packages/h5p-redis-lock\" \"npm run build --workspace=packages/h5p-svg-sanitizer\" \"npm run build --workspace=packages/h5p-clamav-scanner\" \"npm run build --workspace=packages/h5p-mongos3\" && concurrently \"npm run build --workspace=packages/h5p-examples\" \"npm run build:h5p-webcomponents\" && npm run build:h5p-react && npm run build:h5p-shared-state-server",
22+
"clean": "rm -rf typedoc",
2223
"download:content-type-cache": "ts-node scripts/update-real-content-type-cache.ts",
2324
"download:content": "node scripts/download-examples.js test/data/content-type-cache/real-content-types.json test/data/hub-content",
2425
"download:h5p": "sh scripts/install.sh",
@@ -28,8 +29,6 @@
2829
"lint:main": "eslint . --quiet",
2930
"lint": "concurrently \"npm:lint:main\" \"npm:lint:docs\"",
3031
"localize": "./localize.sh",
31-
"postinstall": "concurrently \"npm run build\" \"npm run download:content-type-cache && npm run download:h5p\"",
32-
"pre-commit": "concurrently \"npm:lint\" \"npm:format\"",
3332
"prepare": "husky",
3433
"publish:h5p-express": "cd packages/h5p-express && npm publish",
3534
"publish:h5p-html-exporter": "cd packages/h5p-html-exporter && npm publish",
@@ -38,7 +37,7 @@
3837
"release:publish:dry-run": "lerna publish from-package --dist-tag next --contents build --registry=\"http://localhost:4873/\"",
3938
"release:publish": "lerna publish from-package --dist-tag next --contents build",
4039
"release:version": "lerna version --exact --no-changelog --no-push --no-git-tag-version",
41-
"semantic-release": "semantic-release",
40+
"setup": "concurrently \"npm run build\" \"npm run download:content-type-cache && npm run download:h5p\"",
4241
"start:dbs": "docker-compose -f scripts/mongo-s3-docker-compose.yml up -d",
4342
"start:rest:server": "npm run start --workspace=packages/h5p-rest-example-server",
4443
"start": "npm run start --workspace=packages/h5p-examples",

0 commit comments

Comments
 (0)