Initial release

https://jecdm.cs.put.poznan.pl

Author: MTomczyk

DecisionSupport/src/alternative/AbstractAlternatives.java

@@ -21,7 +21,7 @@ private class ArrayIterator implements Iterator<T>
         private int index = 0;
 
         /**
-         * Checks if has next element.
+         * Checks if it has next element.
          * @return true, if there is next element; false otherwise
          */
         public boolean hasNext()

DecisionSupport/src/dmcontext/DMContext.java

@@ -42,7 +42,7 @@ public static class Params
 
         /**
          * Normalization builder that will be used to generate normalization objects using the OSs (if null,
-         * the standard linear builder will be used ({@link StandardLinearBuilder}).
+         * the standard linear builder will be used ({@link StandardLinearBuilder})).
          */
         public INormalizationBuilder _normalizationBuilder;
 

DecisionSupport/src/inconsistency/IInconsistencyHandler.java

@@ -35,9 +35,9 @@ public interface IInconsistencyHandler<T extends AbstractInternalModel>
     /**
      * Signature for the method responsible for reintroducing consistency.
      *
-     * @param report bundle result of the attempt to construct models (see {@link Report},
+     * @param report bundle result of the attempt to construct models (see {@link Report}),
      *                    it is assumed that this bundle indicates inconsistency ({@link Report#_inconsistencyDetected}).
-     * @param constructor object used to construct the model given the preference information stored in the history object {see {@link History}).
+     * @param constructor object used to construct the model given the preference information stored in the history object (see {@link History}).
      * @param preferenceInformation current preference information (copied from the model system) that can be modified to reintroduce consistency (altered set should be stored in the report);
      *                              the list is derived via {@link History#getPreferenceInformationCopy()}, thus it is valid (e.g., preference statements are ordered from the oldest to the newest)
      * @return the method should reintroduce consistency (e.g., by altering the constructor definition or history

DecisionSupport/src/inconsistency/RemoveOldest.java

@@ -60,15 +60,6 @@ public inconsistency.Report<T> reintroduceConsistency(Report<T> modelBundle,
         if (!modelBundle._inconsistencyDetected)
             throw new InconsistencyHandlerException("Called for inconsistency reintroduction, but the input model bundle reports consistency", this.getClass());
 
-        /*LinkedList<PreferenceInformationWrapper> copiedHistory;
-        try
-        {
-            copiedHistory = history.getPreferenceInformationCopy();
-        } catch (HistoryException e)
-        {
-            throw new InconsistencyHandlerException("Could not copy the preference elicitation history " + e.getDetailedReasonMessage(), this.getClass(), e);
-        }*/
-
         if (preferenceInformation.isEmpty())
             throw new InconsistencyHandlerException("The history of preference elicitation is empty (no reason to reintroduce consistency)", this.getClass());
 

DecisionSupport/src/interaction/trigger/rules/IterationInterval.java

@@ -106,7 +106,7 @@ else if (_postponed > 0)
 
     /**
      * A call-back method that can be used to inform the object that the interaction, although triggered, is postponed
-     * (e.g., due to the unavailability of alternatives). This implementations increases the postponing counter.
+     * (e.g., due to the unavailability of alternatives). This implementation increases the postponing counter.
      *
      * @param postpone object providing auxiliary data related to postponing (e.g., reason)
      */

DecisionSupport/src/model/AbstractPreferenceModel.java

@@ -24,7 +24,7 @@ public abstract class AbstractPreferenceModel<T extends IInternalModel> implemen
     protected final String _name;
 
     /**
-     * This array stores the internal models (extending {@link IInternalModel}.
+     * This array stores the internal models (extending {@link IInternalModel}).
      */
     protected ArrayList<T> _models;
 

DecisionSupport/src/model/constructor/AbstractConstructor.java

@@ -211,7 +211,7 @@ public Report<T> constructModels(LinkedList<PreferenceInformationWrapper> prefer
     }
 
     /**
-     * The pre-construct models phase. This default implementation creates the bundle and fills some some of its fields.
+     * The pre-construct models phase. This default implementation creates the bundle and fills some of its fields.
      *
      * @param preferenceInformation the decision maker's preference information stored (provided via wrappers)
      * @return bundle result object to be filled

DecisionSupport/src/model/constructor/value/frs/FRS.java

@@ -10,8 +10,6 @@
 import model.constructor.random.IRandomModel;
 import model.internals.value.AbstractValueInternalModel;
 import random.IRandom;
-import space.normalization.builder.INormalizationBuilder;
-import space.normalization.builder.StandardLinearBuilder;
 
 import java.util.ArrayList;
 import java.util.LinkedList;
@@ -37,12 +35,6 @@ public static class Params<T extends AbstractValueInternalModel>
          */
         public final IRandomModel<T> _RM;
 
-        /**
-         * Auxiliary normalization builder object that can be used to generate normalization objects.
-         * By default, standard linear builder is used.
-         */
-        public INormalizationBuilder _normalizationBuilder;
-
         /**
          * Limit for the number of samples the FRS method is allowed to generate. Should be positive and greater (or equal)
          * than {@link Params#_feasibleSamplesToGenerate}. In the case of value violation, it is set to 1 or
@@ -82,7 +74,6 @@ public static class Params<T extends AbstractValueInternalModel>
         public Params(IRandomModel<T> RM)
         {
             _RM = RM;
-            _normalizationBuilder = new StandardLinearBuilder();
         }
     }
 

DecisionSupport/src/relation/IUnaryRelation.java

@@ -3,7 +3,7 @@
 import alternative.Alternative;
 
 /**
- * Interface for classes implementing the concept of an unary relation.
+ * Interface for classes implementing the concept of a unary relation.
  *
  * @author MTomczyk
  */

DecisionSupport/src/system/modules/elicitation/PreferenceElicitationModule.java

@@ -374,8 +374,7 @@ private boolean checkIfPreferenceInformationWasDerived(DMResult dmResult)
     {
         if (dmResult == null) return false;
         if (dmResult._feedback == null) return false;
-        if (dmResult._feedback.isEmpty()) return false;
-        return true;
+        return !dmResult._feedback.isEmpty();
     }
 
     /**