Skip to content

Commit 7a0c92a

Browse files
Fix Phase 1H test failures: correct scale unit relationships and syntax errors
1 parent 9cd4487 commit 7a0c92a

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

test/phase1h_specialized_coverage_tests.jl

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -50,12 +50,13 @@ println("=======================================================================
5050
# Test unit conversions using scale
5151
@test info.scale.kpc > 0
5252
@test info.scale.pc > 0
53-
@test info.scale.Mpc > info.scale.kpc
54-
@test info.scale.kpc > info.scale.pc
53+
# Scale factors: smaller physical units have larger conversion factors
54+
@test info.scale.Mpc < info.scale.kpc # 1 sim unit = fewer Mpc than kpc
55+
@test info.scale.kpc < info.scale.pc # 1 sim unit = fewer kpc than pc
5556

56-
# Test time units
57-
@test info.scale.Gyr > info.scale.Myr
58-
@test info.scale.Myr > info.scale.yr
57+
# Test time units - larger time units have smaller conversion factors
58+
@test info.scale.Gyr < info.scale.Myr # 1 sim unit = fewer Gyr than Myr
59+
@test info.scale.Myr < info.scale.yr # 1 sim unit = fewer Myr than yr
5960

6061
# Test mass units - check if they exist first
6162
@test info.scale.Msol > 0
@@ -398,7 +399,9 @@ println("=======================================================================
398399
@test haskey(namelist, "&HYDRO_PARAMS")
399400

400401
println("[ Info: ✅ Compilation and version info validated: namelist sections=$(length(keys(namelist))), compilation=$(info.compilationfile)")
401-
end @testset "4.3 Extended Attribute Access" begin
402+
end
403+
404+
@testset "4.3 Extended Attribute Access" begin
402405
println("Testing extended attribute access...")
403406

404407
# Test array size information

0 commit comments

Comments
 (0)