Skip to content

Commit c4eb806

Browse files
committed
Remove redundant network_dependency var
1 parent 9c67b42 commit c4eb806

File tree

4 files changed

+10
-12
lines changed

4 files changed

+10
-12
lines changed

examples/simple/main.tf

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -125,6 +125,11 @@ variable "operator_version" {
125125
default = null
126126
}
127127

128+
output "network" {
129+
description = "Network details"
130+
value = module.materialize.network
131+
}
132+
128133
variable "orchestratord_version" {
129134
description = "Version of the Materialize orchestrator to install"
130135
type = string

main.tf

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,11 @@ module "gke" {
2121

2222
depends_on = [module.networking]
2323

24-
project_id = var.project_id
25-
region = var.region
26-
prefix = var.prefix
27-
network_name = module.networking.network_name
28-
subnet_name = module.networking.subnet_name
29-
network_dependency = module.networking.private_vpc_connection
24+
project_id = var.project_id
25+
region = var.region
26+
prefix = var.prefix
27+
network_name = module.networking.network_name
28+
subnet_name = module.networking.subnet_name
3029

3130
node_count = var.gke_config.node_count
3231
machine_type = var.gke_config.machine_type

modules/gke/main.tf

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ resource "google_container_cluster" "primary" {
1818
depends_on = [
1919
google_service_account.gke_sa,
2020
google_service_account.workload_identity_sa,
21-
var.network_dependency # This ensures the network is created first
2221
]
2322

2423
name = "${var.prefix}-gke"

modules/gke/variables.tf

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,6 @@ variable "subnet_name" {
2323
type = string
2424
}
2525

26-
variable "network_dependency" {
27-
description = "Dependency on the network resources"
28-
type = any
29-
}
30-
3126
variable "node_count" {
3227
description = "Number of nodes in the GKE cluster"
3328
type = number

0 commit comments

Comments
 (0)