You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Reviewing Pull Requests is a great way to get familiar with the code & architecture of this tool, and to make sure a functionality meets your needs. Each Pull Request has to be approved by at least one one core developer, but having community members helping with this process is significant for the MobilityData team. Additionally, having the eyes of people from different expertise and backgrounds on a contribution makes it higher quality (nobody can think of everything!).
@@ -131,7 +131,7 @@ A critical step in troubleshooting is being able to reproduce the problem. Instr
131
131
132
132
The acceptance test is a key part of the Pull Request process. More information about this test is available in the [ACCEPTANCE_TEST.md](/docs/ACCEPTANCE_TESTS.md) file.
Copy file name to clipboardExpand all lines: docs/RELEASE.md
+11-16Lines changed: 11 additions & 16 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -63,25 +63,20 @@ Uploaded artefacts have versions.
63
63
64
64
* Typically when doing a release the publish_assets.yml Github action is automatically run.
65
65
This will upload some assets
66
-
to be available on the release page itself (see for example [Release 4.1.0 assets](https://github.com/MobilityData/gtfs-validator/releases/tag/v4.1.0#:~:text=7%20other%20contributors-,Assets,-6))
66
+
to be available on the release page itself (see for example [Release 7.1.0 assets](https://github.com/MobilityData/gtfs-validator/releases/tag/v7.1.0))
67
67
68
68
69
-
* This Github action also publishes to Sonatype. This is used as a staging area before making the arftefacts available via Maven Central.
70
-
* See [Sonatype Staging Repositories](https://s01.oss.sonatype.org/#stagingRepositories) (login required)
71
-
*There should be a repository in the list with name orgmobilitydata-####. This is automatically created by Sonatype when files are uploaded.
69
+
* This Github action also publishes to Maven Central.
70
+
* See [Maven Sentral Repository Deployments](https://central.sonatype.com/publishing/deployments) (login required)
71
+
*If the Github action was successful, there should be components in this page:
* You can browse the repo content to make sure everything is there. In particular there should be the jars for the code, jars for javadoc, for sources, and files for the maven pom.
75
+
* You can browse the different components, look at the components files, make sure the version is correct, etc.
77
76
* Everything should be signed, as evidenced by the presence of files with extension .sha1, .sha256, .sha512 etc.
78
-
* Also make sure the version is correct.
79
-
* You then need to manually close the repo. Doing this will trigger acceptance tests for Maven Central.
* Once the repository is closed it becomes available for inclusion in projects for testing. The URL to use as repository in your gradle or maven configuration files can be found in the summary for the repo.
* If for some reason you think the components should not be published, you can press the `Drop` button for each component.
78
+
* If you are satisfied, you can press the `Publish` button for each of the components.
79
+
* The result should be that the components are made available in Maven Central. See [Maven Central Repository](https://repo1.maven.org/maven2/org/mobilitydata/gtfs-validator/) for the published components.
80
+
* They will disappear from the page as you publish or drop them.
85
81
86
-
* Once satisfied with the testing, the repo can be released to Maven Central.
87
-
* Note that once a release is deployed on Maven Central, it cannot be removed or modified. If problems are detected after this stage, a new release with a different version has to be created.
82
+
* Note that once a release is published on Maven Central, it cannot be removed or modified. If problems are detected after this stage, a new release with a different version has to be created.
0 commit comments