Skip to content

Commit 44f1e43

Browse files
committed
BUGFIX GridFS Upload / Problem with different buffer sizes since 4.2.0
1 parent 5e92563 commit 44f1e43

File tree

7 files changed

+12
-10
lines changed

7 files changed

+12
-10
lines changed

CHANGES.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,10 @@
33

44
## Versions
55

6+
### 2.2.4
7+
* mongo-scala-driver [4.2.3](https://mongodb.github.io/mongo-java-driver/4.2/driver-scala/)
8+
* BUGFIX GridFS Upload / Problem with different buffer sizes since 4.2.0
9+
610
### 2.2.3
711
* rollback to mongo-scala-driver [4.1.2](https://mongodb.github.io/mongo-java-driver/4.2/driver-scala/) because of critical bug in GridFS Upload
812

build.sbt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ libraryDependencies += "joda-time" % "joda-time" % "2.10.10" % Test
5555

5656
libraryDependencies += "org.json4s" %% "json4s-native" % "3.6.11" % Test
5757

58-
libraryDependencies += "org.mongodb.scala" %% "mongo-scala-driver" % "4.1.2"
58+
libraryDependencies += "org.mongodb.scala" %% "mongo-scala-driver" % "4.2.3"
5959

6060
libraryDependencies += "org.xerial.snappy" % "snappy-java" % "1.1.8.4" % Provided
6161

project/build.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
sbt.version=1.5.0
1+
sbt.version=1.5.1

src/main/scala/com/sfxcode/nosql/mongo/gridfs/Base.scala

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,10 +57,9 @@ abstract class Base extends LazyLogging {
5757
fileName: String,
5858
file: File,
5959
metadata: AnyRef = Document(),
60-
chunkSizeBytes: Int = 1204 * 256,
61-
bufferSize: Int = 1024 * 64
60+
chunkSizeBytes: Int = 1204 * 256
6261
): Observable[ObjectId] =
63-
upload(fileName, GridFSStreamObservable(file.newInputStream, bufferSize), metadata, chunkSizeBytes)
62+
upload(fileName, GridFSStreamObservable(file.newInputStream, chunkSizeBytes), metadata, chunkSizeBytes)
6463

6564
def download(oid: ObjectId): GridFSDownloadObservable =
6665
gridfsBucket.downloadToObservable(oid)

src/main/scala/com/sfxcode/nosql/mongo/gridfs/Crud.scala

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,8 @@ abstract class Crud extends Search {
1313
fileName: String,
1414
stream: InputStream,
1515
metadata: AnyRef = Document(),
16-
chunkSizeBytes: Int = 1204 * 256,
17-
bufferSize: Int = 1024 * 64
16+
chunkSizeBytes: Int = 1204 * 256
1817
): Observable[ObjectId] =
19-
upload(fileName, GridFSStreamObservable(stream, bufferSize), metadata, chunkSizeBytes)
18+
upload(fileName, GridFSStreamObservable(stream, chunkSizeBytes), metadata, chunkSizeBytes)
2019

2120
}

src/test/scala/com/sfxcode/nosql/mongo/gridfs/GridFSDatabaseSpec.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@ class GridFSDatabaseSpec extends Specification with GridfsDatabaseFunctions with
2626
val fileName = "scala-logo.png"
2727

2828
val filePath = ImageDAOSourcePath + fileName
29-
val oid: ObjectId = insertImage(filePath, ImageMetadata("template1", group = "templates"))
3029
val uploadBytes = File(filePath).bytes.toList
30+
val oid: ObjectId = insertImage(filePath, ImageMetadata("template1", group = "templates"))
3131

3232
val file = findImage(oid)
3333
file.getFilename must be equalTo fileName

src/test/scala/com/sfxcode/nosql/mongo/gridfs/GridfsDatabaseFunctions.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ trait GridfsDatabaseFunctions extends MongoImplicits {
2626

2727
def insertImage(path: String, metadata: AnyRef): ObjectId = {
2828
val file = File(path)
29-
ImageFilesDAO.insertOne(file.name, file.newInputStream, metadata, bufferSize = 1024 * 4)
29+
ImageFilesDAO.insertOne(file.name, file.newInputStream, metadata)
3030
}
3131

3232
def downloadImage(id: ObjectId, path: String): Long = {

0 commit comments

Comments
 (0)