Skip to content

Commit c62a343

Browse files
authored
Fix Google Maps overlay (#1263)
* Fix imageSource.url init * Fix constructor typings * More typings fixes * Reintroduce optional sessionOptions on GoogleCloudAuthPlugin for 3d tiles use where it is not needed
1 parent 3e8e436 commit c62a343

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

src/three/plugins/GoogleCloudAuthPlugin.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ export class GoogleCloudAuthPlugin {
55
autoRefreshToken?: boolean,
66
logoUrl?: string,
77
useRecommendedSettings?: boolean;
8-
sessionOptions?: null | { mapType: string, language: string, region: string },
8+
sessionOptions?: null | { mapType: string, language: string, region: string, [key: string]: any },
99
} );
1010

1111
}

src/three/plugins/images/ImageOverlayPlugin.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ export class GoogleMapsOverlay extends ImageOverlay {
8585
apiToken: string,
8686
autoRefreshToken?: boolean,
8787
logoUrl?: string,
88-
sessionOptions?: null | { mapType: string, language: string, region: string },
88+
sessionOptions: { mapType: string, language: string, region: string, [key: string]: any },
8989

9090
color: number | Color,
9191
opacity: number,

src/three/plugins/images/ImageOverlayPlugin.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1615,7 +1615,7 @@ export class GoogleMapsOverlay extends ImageOverlay {
16151615
.then( json => {
16161616

16171617
this.imageSource.tileDimension = json.tileWidth;
1618-
this.imageSource = 'https://tile.googleapis.com/v1/2dtiles/{z}/{x}/{y}';
1618+
this.imageSource.url = 'https://tile.googleapis.com/v1/2dtiles/{z}/{x}/{y}';
16191619
return this.imageSource.init();
16201620

16211621
} );

0 commit comments

Comments
 (0)