1722249865

Author: Oleh Kulykov

CMakeLists.txt

@@ -117,6 +117,10 @@ if (MSVC)
   else()
     message("MSVC undefined")
   endif()
+  
+  # Run-Time Library
+  # https://learn.microsoft.com/en-us/cpp/build/reference/md-mt-ld-use-run-time-library
+  message("Run-Time Library: ")
   if (LIBPLZMA_OPT_MSVC_MULTITHREAD_STATIC)
     if (CMAKE_BUILD_TYPE MATCHES Debug)
       message("Using Multithreaded Run-Time Debug Library(LIBCMTD.lib)")
@@ -146,10 +150,17 @@ if (MSVC)
 
   if (LIBPLZMA_OPT_DISABLE_RUNTIME_TYPE_INFORMATION)
     # Disable Run-Time Type Information
+    # Defined as 1 if the /GR (Enable Run-Time Type Information) compiler option is set. Otherwise, undefined.
+    # When /GR is on, the compiler defines the _CPPRTTI preprocessor macro.
+    # By default, /GR is on. /GR- disables run-time type information.
+    # However, /GR increases the size of the .rdata sections of your image.
+    # If your code does not use dynamic_cast or typeid, /GR- may produce a smaller image.
+    # https://learn.microsoft.com/en-us/cpp/build/reference/gr-enable-run-time-type-information
     # https://docs.microsoft.com/en-us/cpp/build/reference/gr-enable-run-time-type-information
     # Check vs version: ?view=vs-2015
     set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} /GR-")
     set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /GR-")
+    add_definitions(-DLIBPLZMA_NO_CPP_RTTI=1)
   endif()
 
 else()

src/plzma.cpp

@@ -58,11 +58,20 @@
 #  endif
 #elif defined(LIBPLZMA_MSC)
 // Defined as 1 if the /GR (Enable Run-Time Type Information) compiler option is set. Otherwise, undefined.
+// When /GR is on, the compiler defines the _CPPRTTI preprocessor macro.
+// By default, /GR is on. /GR- disables run-time type information.
+// However, /GR increases the size of the .rdata sections of your image.
+// If your code does not use dynamic_cast or typeid, /GR- may produce a smaller image.
+// https://learn.microsoft.com/en-us/cpp/build/reference/gr-enable-run-time-type-information
 #  if (defined(_CPPRTTI) && (_CPPRTTI > 0))
 #    define RTTI_ENABLED 1
 #  endif
 #endif
 
+#if defined(RTTI_ENABLED) && defined(LIBPLZMA_NO_CPP_RTTI)
+#  error "CMake rtti configuration error."
+#endif
+
 plzma_path_timestamp plzma_path_timestamp_now(void) {
     plzma_path_timestamp t;
     t.last_access = t.last_modification = t.creation = ::time(NULL);
@@ -666,30 +675,30 @@ void plzma_item_out_stream_array_release(plzma_item_out_stream_array * LIBPLZMA_
 
 #if 0
 void plzma_print_memory(int line, const void * LIBPLZMA_NULLABLE mem, const size_t len) {
-    fprintf(stdout, "PRINT MEMORY AT LINE: %i, LEN: %llu\n", line, (unsigned long long)len);
+    ::fprintf(stdout, "PRINT MEMORY AT LINE: %i, LEN: %llu\n", line, (unsigned long long)len);
     if (!mem) {
-        fprintf(stdout, "NULL\n");
-        fflush(stdout);
+        ::fprintf(stdout, "NULL\n");
+        ::fflush(stdout);
         return;
     }
     char buff[256];
     char * s = buff;
     const uint8_t * umem = reinterpret_cast<const uint8_t *>(mem);
     bool hasoutput = false;
     for (size_t i = 0, j = 0; i < len; i++, j++) {
-        int sp = sprintf(s, "0x%02x ", umem[i]);
+        int sp = ::sprintf(s, "0x%02x ", umem[i]);
         s += sp;
         hasoutput = true;
         if (j == 10) {
-            fprintf(stdout, "%s\n", buff);
+            ::fprintf(stdout, "%s\n", buff);
             j = 0;
             s = buff;
             hasoutput = false;
         }
     }
     if (hasoutput) {
-        fprintf(stdout, "%s\n", buff);
+        ::fprintf(stdout, "%s\n", buff);
     }
-    fflush(stdout);
+    ::fflush(stdout);
 }
 #endif // #if 0