Merge pull request #48 from Open-Captable-Protocol/kkolze/added-views

external issuer view

Author: kckplural

chain/script/DeployFactory.s.sol

@@ -57,9 +57,10 @@ library LibDeployment {
             return FacetCutInfo({ name: "DiamondLoupeFacet", selectors: selectors });
         }
         if (facetType == FacetType.Issuer) {
-            bytes4[] memory selectors = new bytes4[](2);
+            bytes4[] memory selectors = new bytes4[](3);
             selectors[0] = IssuerFacet.initializeIssuer.selector;
             selectors[1] = IssuerFacet.adjustIssuerAuthorizedShares.selector;
+            selectors[2] = IssuerFacet.issuer.selector;
             return FacetCutInfo({ name: "IssuerFacet", selectors: selectors });
         }
         if (facetType == FacetType.Stakeholder) {

chain/src/facets/IssuerFacet.sol

@@ -7,12 +7,9 @@ import { Issuer } from "@libraries/Structs.sol";
 import { TxHelper, TxType } from "@libraries/TxHelper.sol";
 import { AccessControl } from "@libraries/AccessControl.sol";
 import { console } from "forge-std/console.sol";
+import { IIssuerFacet } from "@interfaces/IIssuerFacet.sol";
 
-contract IssuerFacet {
-    error IssuerAlreadyInitialized();
-
-    event IssuerAuthorizedSharesAdjusted(uint256 newSharesAuthorized);
-
+contract IssuerFacet is IIssuerFacet {
     /// @notice Initialize the issuer with initial shares authorized
     /// @dev Can only be called once by an admin during setup
     function initializeIssuer(bytes16 id, uint256 initial_shares_authorized) external {
@@ -30,6 +27,10 @@ contract IssuerFacet {
         ds.issuer = Issuer({ id: id, shares_issued: 0, shares_authorized: initial_shares_authorized });
     }
 
+    function issuer() external view returns (Issuer memory) {
+        return StorageLib.get().issuer;
+    }
+
     /// @notice Adjust the total number of authorized shares for the issuer
     /// @dev Only DEFAULT_ADMIN_ROLE can adjust authorized shares
     function adjustIssuerAuthorizedShares(bytes16 id, uint256 newSharesAuthorized) external {

chain/src/interfaces/IIssuerFacet.sol

@@ -16,6 +16,9 @@ interface IIssuerFacet {
     /// @param initial_shares_authorized Initial number of authorized shares
     function initializeIssuer(bytes16 id, uint256 initial_shares_authorized) external;
 
+    /// @notice Getter for the Issuer struct
+    function issuer() external view returns (Issuer memory);
+
     /// @notice Adjust the total number of authorized shares for the issuer
     /// @dev Only DEFAULT_ADMIN_ROLE can adjust authorized shares
     /// @param id The unique identifier for the tx

chain/test/Issuer.t.sol

@@ -0,0 +1,30 @@
+// SPDX-License-Identifier: MIT
+pragma solidity ^0.8.0;
+
+import "./TestBase.sol";
+import {
+    StockActivePosition,
+    WarrantActivePosition,
+    ConvertibleActivePosition,
+    EquityCompensationActivePosition,
+    StakeholderPositions,
+    IssueStockParams,
+    IssueConvertibleParams,
+    IssueEquityCompensationParams,
+    Issuer
+} from "@libraries/Structs.sol";
+import { IStockFacet } from "@interfaces/IStockFacet.sol";
+import { IConvertiblesFacet } from "@interfaces/IConvertiblesFacet.sol";
+import { IEquityCompensationFacet } from "@interfaces/IEquityCompensationFacet.sol";
+import {ICapTable} from "../src/interfaces/ICapTable.sol";
+
+contract IssuerTest is DiamondTestBase {
+
+    function test_issuer() public {
+        ICapTable ct = ICapTable(address(capTable));
+        Issuer memory iss = ct.issuer();
+        assertTrue(iss.id != bytes16(0));
+        assertGt(iss.shares_authorized, 0);
+        assertEq(iss.shares_issued, 0);
+    }
+}