Reformat the whole project with clang-format

Done with pre-commit run -a, so the version
defined in pre-commit config is used.

This also changes the Github workflow so that
there is no commit that fails GHA.

Change-Id: I2566ad493629e1f5fdfa6f6483b8973463404e3e
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: <20250804151853.10565-1-gert@greenie.muc.de>
URL: https://gerrit.openvpn.net/c/openvpn/+/791
Signed-off-by: Gert Doering <gert@greenie.muc.de>

Author: flichtenheld

.github/workflows/build.yaml

@@ -5,35 +5,26 @@ on:
   pull_request:
 
 jobs:
-  checkuncrustify:
-    name: "Check code style with Uncrustify"
-    # Ubuntu 22.04 has uncrustify 0.72_f
-    runs-on: ubuntu-22.04
+  clang-format:
+    name: Check code style with clang-format
+    runs-on: ubuntu-24.04
     steps:
       - name: Install dependencies
-        run: sudo apt update && sudo apt install -y uncrustify
+        run: |
+          sudo apt update && sudo apt install -y python3-pip
+          pip3 install pre-commit
       - name: Checkout OpenVPN
         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
-        with:
-          path: openvpn
-      - name: Show uncrustify version
-        run: uncrustify --version
-      - name: Run uncrustify
-        run: ./dev-tools/reformat-all.sh
-        working-directory: openvpn
+      - name: Run clang-format
+        run: pre-commit run -a --show-diff-on-failure || true
       - name: Check for changes
-        run: git diff --output=uncrustify-changes.patch
-        working-directory: openvpn
-      - name: Show changes on standard output
-        run: git diff
-        working-directory: openvpn
+        run: git diff --output=format-changes.patch
       - uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
         with:
-          name: uncrustify-changes.patch
-          path: 'openvpn/uncrustify-changes.patch'
+          name: format-changes.patch
+          path: format-changes.patch
       - name: Set job status
-        run: test ! -s uncrustify-changes.patch
-        working-directory: openvpn
+        run: test ! -s format-changes.patch
 
   android:
     strategy:

include/openvpn-msg.h

@@ -26,7 +26,8 @@
 #include <windef.h>
 #include <ws2tcpip.h>
 
-typedef enum {
+typedef enum
+{
     msg_acknowledgement,
     msg_add_address,
     msg_del_address,
@@ -50,36 +51,42 @@ typedef enum {
     msg_create_adapter
 } message_type_t;
 
-typedef struct {
+typedef struct
+{
     message_type_t type;
     size_t size;
     int message_id;
 } message_header_t;
 
-typedef union {
+typedef union
+{
     struct in_addr ipv4;
     struct in6_addr ipv6;
 } inet_address_t;
 
-typedef struct {
+typedef struct
+{
     int index;
     char name[256];
 } interface_t;
 
-typedef enum {
-    wfp_block_local = 1<<0,
-    wfp_block_dns = 1<<1
+typedef enum
+{
+    wfp_block_local = 1 << 0,
+    wfp_block_dns = 1 << 1
 } wfp_block_flags_t;
 
-typedef struct {
+typedef struct
+{
     message_header_t header;
     short family;
     inet_address_t address;
     int prefix_len;
     interface_t iface;
 } address_message_t;
 
-typedef struct {
+typedef struct
+{
     message_header_t header;
     short family;
     inet_address_t prefix;
@@ -89,7 +96,8 @@ typedef struct {
     int metric;
 } route_message_t;
 
-typedef struct {
+typedef struct
+{
     message_header_t header;
     interface_t iface;
     char domains[512];
@@ -99,14 +107,16 @@ typedef struct {
 } dns_cfg_message_t;
 
 
-typedef enum {
+typedef enum
+{
     nrpt_dnssec
 } nrpt_flags_t;
 
-#define NRPT_ADDR_NUM 8   /* Max. number of addresses */
+#define NRPT_ADDR_NUM  8  /* Max. number of addresses */
 #define NRPT_ADDR_SIZE 48 /* Max. address strlen + some */
 typedef char nrpt_address_t[NRPT_ADDR_SIZE];
-typedef struct {
+typedef struct
+{
     message_header_t header;
     interface_t iface;
     nrpt_address_t addresses[NRPT_ADDR_NUM];
@@ -115,14 +125,16 @@ typedef struct {
     nrpt_flags_t flags;
 } nrpt_dns_cfg_message_t;
 
-typedef struct {
+typedef struct
+{
     message_header_t header;
     interface_t iface;
     int addr_len;
     inet_address_t addr[4]; /* support up to 4 dns addresses */
 } wins_cfg_message_t;
 
-typedef struct {
+typedef struct
+{
     message_header_t header;
     interface_t iface;
     int disable_nbt;
@@ -134,41 +146,48 @@ typedef struct {
 
 /* TODO: NTP */
 
-typedef struct {
+typedef struct
+{
     message_header_t header;
     short family;
     interface_t iface;
 } flush_neighbors_message_t;
 
-typedef struct {
+typedef struct
+{
     message_header_t header;
     int error_number;
 } ack_message_t;
 
-typedef struct {
+typedef struct
+{
     message_header_t header;
     wfp_block_flags_t flags;
     interface_t iface;
 } wfp_block_message_t;
 
-typedef struct {
+typedef struct
+{
     message_header_t header;
     interface_t iface;
 } enable_dhcp_message_t;
 
-typedef struct {
+typedef struct
+{
     message_header_t header;
     interface_t iface;
     short family;
     int mtu;
 } set_mtu_message_t;
 
-typedef enum {
+typedef enum
+{
     ADAPTER_TYPE_DCO,
     ADAPTER_TYPE_TAP,
 } adapter_type_t;
 
-typedef struct {
+typedef struct
+{
     message_header_t header;
     adapter_type_t adapter_type;
 } create_adapter_message_t;