Fix: improper order in if-else oneliner

MateuszGrabuszynski · MateuszGrabuszynski · commit d6fcab137a5d · 2025-08-13T15:04:05.000Z
diff --git a/tests/validation/create_pcap_file/netsniff.py b/tests/validation/create_pcap_file/netsniff.py
@@ -61,7 +61,7 @@ def start(self, startup_wait=STARTUP_WAIT):
                     str(self.interface), # FIXME: It is not a proper interface name to be used here
                     "--out",
                     self.pcap_file,
-                    if filter f"-f {self.filter}" else "",
+                    f"-f {self.filter}" if filter else "",
                 ]
                 logger.info(f"Running command: {' '.join(cmd)}")
                 self.netsniff_process = connection.start_process(

Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ def start(self, startup_wait=STARTUP_WAIT):`
`61`	`61`	`str(self.interface), # FIXME: It is not a proper interface name to be used here`
`62`	`62`	`"--out",`
`63`	`63`	`self.pcap_file,`
`64`		`- if filter f"-f {self.filter}" else "",`
	`64`	`+ f"-f {self.filter}" if filter else "",`
`65`	`65`	`]`
`66`	`66`	`logger.info(f"Running command: {' '.join(cmd)}")`
`67`	`67`	`self.netsniff_process = connection.start_process(`