Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

Commit 0ab7c86

Browse files
committed
Worked around the increased BDBR regression issue.
The regression was caused by the tile group implementation (PR #348), when ImproveSharpness is used, as it would impact the QP values of each CU and latter mode decision process. So temporarily work around the issue and need to fix it in the future. Signed-off-by: Austin Hu <austin.hu@intel.com>
1 parent 58b3593 commit 0ab7c86

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

Source/Lib/Codec/EbDefinitions.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,8 @@ extern "C" {
5454
typedef int errno_t;
5555
#endif /* _ERRNO_T_DEFINED */
5656

57-
58-
57+
// To sharpen frame background.
58+
#define USE_SOURCE_REFERENCE 0
5959

6060
//Maximum 8192x4320
6161
#define EB_TILE_COLUMN_MAX_COUNT 20u

Source/Lib/Codec/EbPictureDecisionProcess.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1020,9 +1020,15 @@ void* PictureDecisionKernel(void *inputPtr)
10201020

10211021
pictureControlSetPtr->disableTmvpFlag = sequenceControlSetPtr->staticConfig.unrestrictedMotionVector == 0 ? EB_TRUE : EB_FALSE;
10221022

1023+
// FIXME: work around the increased BDBR regression issue induced by the
1024+
// tile group implementation (PR #348), when ImproveSharpness is used.
1025+
#if USE_SOURCE_REFERENCE
10231026
pictureControlSetPtr->useSrcRef = (sequenceControlSetPtr->staticConfig.improveSharpness && pictureControlSetPtr->temporalLayerIndex > 0) ?
10241027
EB_TRUE :
10251028
EB_FALSE;
1029+
#else
1030+
pictureControlSetPtr->useSrcRef = EB_FALSE;
1031+
#endif
10261032

10271033
SignalDerivationMultiProcessesOq(
10281034
sequenceControlSetPtr,

0 commit comments

Comments
 (0)