PHP 8.5: Deprecation notices around string incrementing

[TobiasBg]

I have run some early tests of PhpSpreadsheet 5.0 on PHP 8.5.0-beta1, which has been made available in preparation for the November release of PHP 8.5.

PhpSpreadsheet is now affected by a few deprecations.
So far, I have seen
Increment on non-numeric string is deprecated, use str_increment() instead
being raised in
https://github.com/PHPOffice/PhpSpreadsheet/blob/5.0.0/src/PhpSpreadsheet/Worksheet/Worksheet.php#L2946
https://github.com/PHPOffice/PhpSpreadsheet/blob/5.0.0/src/PhpSpreadsheet/Reader/Xlsx/ColumnAndRowAttributes.php#L145
https://github.com/PHPOffice/PhpSpreadsheet/blob/5.0.0/src/PhpSpreadsheet/Reader/Xls.php#L3578
https://github.com/PHPOffice/PhpSpreadsheet/blob/5.0.0/src/PhpSpreadsheet/Reader/Csv.php#L452

Other parts of the code where the column letter for a column is incremented/decremented will likely be affected, too.

Details for this deprecation (which follow a "soft-deprecation" in PHP 8.3) can be found at https://wiki.php.net/rfc/deprecations_php_8_5#enact_follow-up_phase_of_the_path_to_saner_incrementdecrement_operators_rfc

[oleibman]

Thank you. I have been testing with Php 8.5. This is new in the last day or so, and very unwelcome. I was not expecting this till Php 9. I guess I will be busy over the next little while.

[oleibman]

Yipe! 2.225 errors. And Php8.5 nightly on my system is not reproducing them yet. Ugh!

[TobiasBg]

Yes, looks like this was only committed on Saturday :-/

[oleibman]

And I now have a version of 8.5 on my local system that reproduces this error. I think my plan will be to first detect and suppress this message in the test suite bootstrap. Once that is in place, I can start updating the src code.