Remove some debug logging

Author: kklimonda-cl

assets/pango/movement/movement.go

@@ -251,20 +251,17 @@ type sequencePosition struct {
 }
 
 func updateSimulatedIdxMap(idxMap *map[Movable]int, moved Movable, startingIdx int, targetIdx int) {
-	slog.Debug("updateSimulatedIdxMap", "entries", idxMap)
 	for entry, idx := range *idxMap {
 		if entry == moved {
 			continue
 		}
 
-		slog.Debug("updateSimulatedIdxMap", "entry", entry, "idx", idx, "startingIdx", startingIdx, "targetIdx", targetIdx)
 		if startingIdx > targetIdx && idx >= targetIdx {
 			(*idxMap)[entry] = idx + 1
 		} else if startingIdx < targetIdx && idx >= startingIdx && idx <= targetIdx {
 			(*idxMap)[entry] = idx - 1
 		}
 	}
-	slog.Debug("updateSimulatedIdxMap", "entries", idxMap)
 }
 
 func OptimizeMovements(existing []Movable, expected []Movable, entries []Movable, actions []MoveAction, position any) []MoveAction {
@@ -277,10 +274,7 @@ func OptimizeMovements(existing []Movable, expected []Movable, entries []Movable
 	var optimized []MoveAction
 
 	switch position.(type) {
-	case PositionBefore:
-		slog.Debug("OptimizeMovements()", "position", position, "type", fmt.Sprintf("%T", position))
-	case PositionAfter:
-		slog.Debug("OptimizeMovements()", "position", position, "type", fmt.Sprintf("%T", position))
+	case PositionBefore, PositionAfter:
 	default:
 		return actions
 	}
@@ -298,22 +292,19 @@ func OptimizeMovements(existing []Movable, expected []Movable, entries []Movable
 		case ActionWhereBottom:
 			targetIdx = len(simulated) - 1
 		case ActionWhereBefore:
-			slog.Debug("OptimizeMovements()", "dest", action.Destination, "destIdx", simulatedIdxMap[action.Destination])
 			targetIdx = simulatedIdxMap[action.Destination] - 1
 		case ActionWhereAfter:
 			targetIdx = simulatedIdxMap[action.Destination] + 1
 		}
 
-		slog.Debug("OptimizeMovements()", "action", action, "currentIdx", currentIdx, "targetIdx", targetIdx)
 		if targetIdx != currentIdx {
 			optimized = append(optimized, action)
 			simulatedIdxMap[action.Movable] = targetIdx
 			updateSimulatedIdxMap(&simulatedIdxMap, action.Movable, currentIdx, targetIdx)
 		}
 	}
 
-	slog.Debug("OptimizeMovements()", "optimized", optimized)
-
+	slog.Debug("OptimiveMovements()", "optimized", optimized)
 	return optimized
 }
 
@@ -348,50 +339,35 @@ func GenerateMovements(existing []Movable, expected []Movable, entries []Movable
 
 	var movements []MoveAction
 
-	var commonStartIdx, commonEndIdx int
-	if commonLen > 0 {
-		commonStartIdx = expectedIdxMap[common[0]]
-		commonEndIdx = expectedIdxMap[common[commonLen-1]]
-	}
-
-	slog.Debug("GenerateMovements()", "expected", expected)
-	slog.Debug("GenerateMovements()", "existing", existing)
-	slog.Debug("GenerateMovements()", "common", common, "commonStartIdx", commonStartIdx, "commonEndIdx", commonEndIdx)
 	var previous Movable
 	for _, elt := range entries {
-		slog.Debug("GenerateMovements()", "elt", elt, "existing", existingIdxMap[elt], "expected", expectedIdxMap[elt])
 		// If existing index for the element matches the expected one, skip it over
 		if existingIdxMap[elt] == expectedIdxMap[elt] {
 			continue
 		}
 
 		if expectedIdxMap[elt] == 0 {
-			slog.Debug("HELP1")
 			movements = append(movements, MoveAction{
 				Movable:     elt,
 				Destination: nil,
 				Where:       ActionWhereTop,
 			})
 			previous = elt
 		} else if expectedIdxMap[elt] == len(expectedIdxMap) {
-			slog.Debug("HELP2")
 			movements = append(movements, MoveAction{
 				Movable:     elt,
 				Destination: nil,
 				Where:       ActionWhereBottom,
 			})
 			previous = elt
 		} else if previous != nil {
-			slog.Debug("HELP3")
-
 			movements = append(movements, MoveAction{
 				Movable:     elt,
 				Destination: previous,
 				Where:       ActionWhereAfter,
 			})
 			previous = elt
 		} else {
-			slog.Debug("HELP4")
 			var where ActionWhereType
 
 			switch movement {

assets/pango/movement/movement_test.go

@@ -132,7 +132,7 @@ var _ = Describe("Movement", func() {
 				Expect(moves).To(HaveLen(0))
 			})
 			Context("and moved entries are out of order", func() {
-				FIt("should generate a single command to move B before D", func() {
+				It("should generate a single command to move B before D", func() {
 					// A B C D E -> A B C E D
 					entries := asMovable([]string{"E", "D"})
 					moves, err := movement.MoveGroup(
@@ -168,7 +168,7 @@ var _ = Describe("Movement", func() {
 				})
 			})
 			Context("and moved entries are out of order", func() {
-				FIt("should generate a single command to move B before D", func() {
+				It("should generate a single command to move B before D", func() {
 					// A B C D E -> A C B D E
 					entries := asMovable([]string{"C", "B"})
 					moves, err := movement.MoveGroup(