Fixed a bug related to geometric mean calculation.

ozgunbabur · ozgunbabur · commit 60d4e42bf6e6 · 2024-01-25T11:20:15.000-05:00
diff --git a/src/main/java/org/panda/causalpath/analyzer/ThresholdDetector.java b/src/main/java/org/panda/causalpath/analyzer/ThresholdDetector.java
@@ -88,6 +88,8 @@ public OneDataChangeDetector makeACopy()
 	 */
 	public double foldChangeGeometricMean(double[] vals)
 	{
+		if (vals.length == 1) return vals[0];
+
 		double mult = 1;
 		int cnt = 0;
 		for (double val : vals)
@@ -96,7 +98,9 @@ public double foldChangeGeometricMean(double[] vals)
 			cnt++;
 			mult *= val < 0 ? -1 / val : val;
 		}
-		return Math.pow(mult, 1D / cnt);
+		double result = Math.pow(mult, 1D / cnt);
+		if (result < 1) result = - 1 / result;
+		return result;
 	}
 
 	public double maxOfAbs(double[] vals)

Original file line number	Diff line number	Diff line change
`@@ -88,6 +88,8 @@ public OneDataChangeDetector makeACopy()`
`88`	`88`	`*/`
`89`	`89`	`public double foldChangeGeometricMean(double[] vals)`
`90`	`90`	`{`
	`91`	`+ if (vals.length == 1) return vals[0];`
	`92`	`+`
`91`	`93`	`double mult = 1;`
`92`	`94`	`int cnt = 0;`
`93`	`95`	`for (double val : vals)`
`@@ -96,7 +98,9 @@ public double foldChangeGeometricMean(double[] vals)`
`96`	`98`	`cnt++;`
`97`	`99`	`mult *= val < 0 ? -1 / val : val;`
`98`	`100`	`}`
`99`		`- return Math.pow(mult, 1D / cnt);`
	`101`	`+ double result = Math.pow(mult, 1D / cnt);`
	`102`	`+ if (result < 1) result = - 1 / result;`
	`103`	`+ return result;`
`100`	`104`	`}`
`101`	`105`
`102`	`106`	`public double maxOfAbs(double[] vals)`