optimize the relationships

MoamenEltouny · web-flow · commit ba4f07c311ba · 2022-03-13T20:45:04.000+02:00
diff --git a/src/HasFiles.php b/src/HasFiles.php
@@ -15,6 +15,7 @@
 trait HasFiles
 {
     use HasCustomAttributes;
+    
     /**
      * Files Atrributes on Save/Create
      *
@@ -149,7 +150,13 @@ public function isFileAttribute(string $key): bool
      */
     public function files()
     {
-        return $this->morphMany(File::class, 'model');
+        $hasThumbnails = false;
+        
+        foreach ($this->filesOptions ?? [] as $options)
+            if (isset($options['thumbnail']))
+                $hasThumbnails = true;
+
+        return $this->morphMany(File::class, 'model')->with($hasThumbnails ? 'file.thumbnail' : 'file');
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -15,6 +15,7 @@`
`15`	`15`	`trait HasFiles`
`16`	`16`	`{`
`17`	`17`	`use HasCustomAttributes;`
	`18`	`+`
`18`	`19`	`/**`
`19`	`20`	`* Files Atrributes on Save/Create`
`20`	`21`	`*`
`@@ -149,7 +150,13 @@ public function isFileAttribute(string $key): bool`
`149`	`150`	`*/`
`150`	`151`	`public function files()`
`151`	`152`	`{`
`152`		`- return $this->morphMany(File::class, 'model');`
	`153`	`+ $hasThumbnails = false;`
	`154`	`+`
	`155`	`+ foreach ($this->filesOptions ?? [] as $options)`
	`156`	`+ if (isset($options['thumbnail']))`
	`157`	`+ $hasThumbnails = true;`
	`158`	`+`
	`159`	`+ return $this->morphMany(File::class, 'model')->with($hasThumbnails ? 'file.thumbnail' : 'file');`
`153`	`160`	`}`
`154`	`161`
`155`	`162`	`/**`