Fix invalid strlcpy invocation.

Henceforth guarded via -Werror=strlcpy-strlcat-size where supported.

Author: dsvensson

CMakeLists.txt

@@ -160,6 +160,11 @@ else()
 		target_compile_options(${PROJECT_NAME} PRIVATE -Werror=strict-prototypes)
 	endif()
 
+	check_c_compiler_flag("-Wstrlcpy-strlcat-size" HAS_STRLCPY_STRLCAT_SIZE)
+	if (HAS_STRLCPY_STRLCAT_SIZE)
+		target_compile_options(${PROJECT_NAME} PRIVATE -Werror=strlcpy-strlcat-size)
+	endif()
+
 	# Do not allow undefined symbols while linking.
 	if(APPLE)
 		target_link_options(${PROJECT_NAME} PRIVATE "-Wl,-undefined,error")

src/race.c

@@ -3584,17 +3584,17 @@ void read_topscores(void)
 			race_fgets(line, MAX_TXTLEN);
 			race.records[cnt].time = atof(line);
 			race_fgets(line, MAX_TXTLEN);
-			strlcpy(race.records[cnt].racername, line, strlen(line));
+			strlcpy(race.records[cnt].racername, line, sizeof(race.records[cnt].racername));
 			race_fgets(line, MAX_TXTLEN);
-			strlcpy(race.records[cnt].demoname, line, strlen(line));
+			strlcpy(race.records[cnt].demoname, line, sizeof(race.records[cnt].demoname));
 			race_fgets(line, MAX_TXTLEN);
 			race.records[cnt].distance = atof(line);
 			race_fgets(line, MAX_TXTLEN);
 			race.records[cnt].maxspeed = atof(line);
 			race_fgets(line, MAX_TXTLEN);
 			race.records[cnt].avgspeed = atof(line);
 			race_fgets(line, MAX_TXTLEN);
-			strlcpy(race.records[cnt].date, line, strlen(line));
+			strlcpy(race.records[cnt].date, line, sizeof(race.records[cnt].date));
 			race_fgets(line, MAX_TXTLEN);
 			race.records[cnt].weaponmode = atoi(line);
 			race_fgets(line, MAX_TXTLEN);