Skip to content

Commit fda6b80

Browse files
committed
Remove undefined CellReference::fromString
FIXES: #327
1 parent 35c6d27 commit fda6b80

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

QXlsx/header/xlsxcellreference.h

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,6 @@
77

88
QT_BEGIN_NAMESPACE_XLSX
99

10-
const int XLSX_ROW_MAX = 1048576;
11-
const int XLSX_COLUMN_MAX = 16384;
12-
const int XLSX_STRING_MAX = 32767;
13-
1410
class QXLSX_EXPORT CellReference
1511
{
1612
public:
@@ -29,7 +25,6 @@ class QXLSX_EXPORT CellReference
2925
~CellReference();
3026

3127
QString toString(bool row_abs = false, bool col_abs = false) const;
32-
static CellReference fromString(const QString &cell);
3328
bool isValid() const;
3429
inline void setRow(int row) { _row = row; }
3530
inline void setColumn(int col) { _column = col; }
@@ -47,7 +42,7 @@ class QXLSX_EXPORT CellReference
4742

4843
inline bool operator>(const CellReference &other) const
4944
{
50-
return _row > other._row || _column != other._column;
45+
return _row > other._row || _column != other._column;
5146
}
5247

5348
private:

QXlsx/source/xlsxworksheet.cpp

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,12 @@
4242

4343
QT_BEGIN_NAMESPACE_XLSX
4444

45+
namespace {
46+
const int XLSX_ROW_MAX = 1048576;
47+
const int XLSX_COLUMN_MAX = 16384;
48+
const int XLSX_STRING_MAX = 32767;
49+
} // namespace
50+
4551
WorksheetPrivate::WorksheetPrivate(Worksheet *p, Worksheet::CreateFlag flag)
4652
: AbstractSheetPrivate(p, flag)
4753
, windowProtection(false)

0 commit comments

Comments
 (0)