Improved: ConfigService now clones ItemsByFolder to avoid issues with concurrent access

Sewer56 · Sewer56 · commit dfa9b4ebbc6d · 2024-10-17T22:41:16.000+01:00
diff --git a/source/Reloaded.Mod.Loader.IO/Services/ConfigServiceBase.cs b/source/Reloaded.Mod.Loader.IO/Services/ConfigServiceBase.cs
@@ -188,7 +188,7 @@ private void OnDeleteDirectory(object sender, FileSystemEventArgs e)
         // Otherwise iterate over all possible subfolders.
         // This is a bit inefficient, but with nested mods, it's the only way (without creating a whole tree of nodes).
         // Can rack up upwards of 20ms in huge mod directories.
-        foreach (var item in ItemsByFolder)
+        foreach (var item in ItemsByFolder.ToArray())
         {
             var modFolder = item.Key;
             if (!Path.EndsInDirectorySeparator(modFolder))

Original file line number	Diff line number	Diff line change
`@@ -188,7 +188,7 @@ private void OnDeleteDirectory(object sender, FileSystemEventArgs e)`
`188`	`188`	`// Otherwise iterate over all possible subfolders.`
`189`	`189`	`// This is a bit inefficient, but with nested mods, it's the only way (without creating a whole tree of nodes).`
`190`	`190`	`// Can rack up upwards of 20ms in huge mod directories.`
`191`		`- foreach (var item in ItemsByFolder)`
	`191`	`+ foreach (var item in ItemsByFolder.ToArray())`
`192`	`192`	`{`
`193`	`193`	`var modFolder = item.Key;`
`194`	`194`	`if (!Path.EndsInDirectorySeparator(modFolder))`