Fixing a critical issue in MTU mismatch that may cause segfault

RoySenpai · RoySenpai · commit dcc0353231a2 · 2024-11-11T23:41:20.000+02:00
diff --git a/src/rudp_lib.cpp b/src/rudp_lib.cpp
@@ -558,7 +558,7 @@ int RUDP_Socket_p::recv(void *buffer, uint32_t buffer_size)
 		RUDP_header *header = (RUDP_header *)packet;
 		uint32_t packet_seq_num = ntohl(header->seq_num);
 		uint16_t packet_size = ntohs(header->length);
-		uint32_t offset = ntohl(header->seq_num) * (m_protocolMTU - sizeof(RUDP_header));
+		uint32_t offset = ntohl(header->seq_num) * (std::min(m_protocolMTU, m_peersMTU) - sizeof(RUDP_header));
 
 		if (packet_seq_num == prev_seq_num)
 		{

Original file line number	Diff line number	Diff line change
`@@ -558,7 +558,7 @@ int RUDP_Socket_p::recv(void *buffer, uint32_t buffer_size)`
`558`	`558`	`RUDP_header header = (RUDP_header )packet;`
`559`	`559`	`uint32_t packet_seq_num = ntohl(header->seq_num);`
`560`	`560`	`uint16_t packet_size = ntohs(header->length);`
`561`		`- uint32_t offset = ntohl(header->seq_num) * (m_protocolMTU - sizeof(RUDP_header));`
	`561`	`+ uint32_t offset = ntohl(header->seq_num) * (std::min(m_protocolMTU, m_peersMTU) - sizeof(RUDP_header));`
`562`	`562`
`563`	`563`	`if (packet_seq_num == prev_seq_num)`
`564`	`564`	`{`