Skip to content

Unit conversion in P452 propagation model #42

@edgar-souza

Description

@edgar-souza
  • SHARC version: 0.0.1
  • Python version: 3.5
  • Operating System: Windows

Description

Frequency and distance units should be stored in MHz and meters, respectively, in order to keep consistency with other parts of simulator. This is not necessarily a bug (since code is working fine), but it has to be fixed in the whole P.452 implementation.

What I Did

This issue was found after code reviewing. Examples: lines 19 and 20 of file propagation_gases_attenuation.py:

d = np.asarray(kwargs["distance"]) #Km
f = np.asarray(kwargs["frequency"]) #GHz

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions