Skip to content

Commit 36a69e1

Browse files
Code refactoring
1 parent c391ca0 commit 36a69e1

File tree

6 files changed

+20
-20
lines changed

6 files changed

+20
-20
lines changed

sormas-api/src/main/java/de/symeda/sormas/api/contact/ContactDto.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -152,8 +152,8 @@ public class ContactDto extends SormasToSormasShareableDto implements IsContact
152152
public static final String DELETION_REASON = "deletionReason";
153153
public static final String OTHER_DELETION_REASON = "otherDeletionReason";
154154
public static final String PROPHYLAXIS_PRESCRIBED = "prophylaxisPrescribed";
155-
public static final String DRUG = "prescribedDrug";
156-
public static final String DRUG_TEXT = "prescribedDrugText";
155+
public static final String PRESCRIBED_DRUG = "prescribedDrug";
156+
public static final String PRESCRIBED_DRUG_TEXT = "prescribedDrugText";
157157

158158
@EmbeddedPersonalData
159159
private CaseReferenceDto caze;

sormas-api/src/main/java/de/symeda/sormas/api/contact/ContactIndexDto.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,8 @@ public class ContactIndexDto extends PseudonymizableIndexDto implements IsContac
6464
public static final String DISTRICT_UUID = "districtUuid";
6565
public static final String COMMUNITY_UUID = "communityUuid";
6666
public static final String PROPHYLAXIS_PRESCRIBED = "prophylaxisPrescribed";
67-
public static final String DRUG = "prescribedDrug";
68-
public static final String DRUG_TEXT = "prescribedDrugText";
67+
public static final String PRESCRIBED_DRUG = "prescribedDrug";
68+
public static final String PRESCRIBED_DRUG_TEXT = "prescribedDrugText";
6969

7070
private String personUuid;
7171
@PersonalData

sormas-backend/src/main/java/de/symeda/sormas/backend/contact/Contact.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -170,8 +170,8 @@ public class Contact extends CoreAdo implements IsContact, SormasToSormasShareab
170170
public static final String DUPLICATE_OF = "duplicateOf";
171171
public static final String SELF_REPORT ="selfReport";
172172
public static final String PROPHYLAXIS_PRESCRIBED ="prophylaxisPrescribed";
173-
public static final String DRUG ="prescribedDrug";
174-
public static final String DRUG_TEXT ="prescribedDrugText";
173+
public static final String PRESCRIBED_DRUG ="prescribedDrug";
174+
public static final String PRESCRIBED_DRUG_TEXT ="prescribedDrugText";
175175

176176
private Date reportDateTime;
177177
private User reportingUser;

sormas-backend/src/main/java/de/symeda/sormas/backend/contact/ContactListCriteriaBuilder.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -193,8 +193,8 @@ private List<Expression<?>> getIndexOrders(SortProperty sortProperty, Root<Conta
193193
case ContactIndexDto.CASE_CLASSIFICATION:
194194
case ContactIndexDto.VACCINATION_STATUS:
195195
case ContactIndexDto.PROPHYLAXIS_PRESCRIBED:
196-
case ContactIndexDto.DRUG:
197-
case ContactIndexDto.DRUG_TEXT:
196+
case ContactIndexDto.PRESCRIBED_DRUG:
197+
case ContactIndexDto.PRESCRIBED_DRUG_TEXT:
198198
expressions.add(contact.get(sortProperty.propertyName));
199199
break;
200200
case ContactIndexDto.EXTERNAL_ID:
@@ -326,8 +326,8 @@ private <T> CriteriaQuery<T> buildIndexCriteria(
326326
selections.addAll(selectionProvider.apply(contact, contactQueryContext));
327327
selections.add(cb.size(contact.get(Contact.VISITS)));
328328
selections.add(contact.get(Contact.PROPHYLAXIS_PRESCRIBED));
329-
selections.add(contact.get(Contact.DRUG));
330-
selections.add(contact.get(Contact.DRUG_TEXT));
329+
selections.add(contact.get(Contact.PRESCRIBED_DRUG));
330+
selections.add(contact.get(Contact.PRESCRIBED_DRUG_TEXT));
331331
// This is needed in selection because of the combination of distinct and orderBy clauses - every operator in the orderBy has to be part of the select IF distinct is used
332332
}
333333

sormas-ui/src/main/java/de/symeda/sormas/ui/contact/AbstractContactGrid.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,7 @@ protected Stream<String> getColumnList() {
219219
ContactIndexDto.FOLLOW_UP_UNTIL,
220220
ContactIndexDto.SYMPTOM_JOURNAL_STATUS,
221221
ContactIndexDto.VACCINATION_STATUS,
222-
NUMBER_OF_VISITS, ContactIndexDto.PROPHYLAXIS_PRESCRIBED, ContactIndexDto.DRUG),
222+
NUMBER_OF_VISITS, ContactIndexDto.PROPHYLAXIS_PRESCRIBED, ContactIndexDto.PRESCRIBED_DRUG),
223223
Stream.of(NUMBER_OF_PENDING_TASKS).filter(column -> UiUtil.permitted(FeatureType.TASK_MANAGEMENT, UserRight.TASK_VIEW)),
224224
Stream.of(COLUMN_COMPLETENESS),
225225
Stream.of(DELETE_REASON_COLUMN))

sormas-ui/src/main/java/de/symeda/sormas/ui/contact/ContactDataForm.java

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ public class ContactDataForm extends AbstractEditForm<ContactDto> {
141141
fluidRowLocs(ContactDto.RELATION_DESCRIPTION) +
142142
fluidRowLocs(ContactDto.DESCRIPTION) +
143143
loc(PROPHYLAXIS_LOC)+
144-
fluidRowLocs(4,ContactDto.PROPHYLAXIS_PRESCRIBED, 4, ContactDto.DRUG, 4, ContactDto.DRUG_TEXT) +
144+
fluidRowLocs(4,ContactDto.PROPHYLAXIS_PRESCRIBED, 4, ContactDto.PRESCRIBED_DRUG, 4, ContactDto.PRESCRIBED_DRUG_TEXT) +
145145
fluidRowLocs(6, ContactDto.PROHIBITION_TO_WORK, 3, ContactDto.PROHIBITION_TO_WORK_FROM, 3, ContactDto.PROHIBITION_TO_WORK_UNTIL) +
146146
fluidRowLocs(4, ContactDto.QUARANTINE_HOME_POSSIBLE, 8, ContactDto.QUARANTINE_HOME_POSSIBLE_COMMENT) +
147147
fluidRowLocs(4, ContactDto.QUARANTINE_HOME_SUPPLY_ENSURED, 8, ContactDto.QUARANTINE_HOME_SUPPLY_ENSURED_COMMENT) +
@@ -487,7 +487,7 @@ protected void addFields() {
487487
contactOfficerField.setEnabled(true);
488488
contactOfficerField.setParentPseudonymizedSupplier(() -> getValue().isPseudonymized());
489489

490-
addField(ContactDto.DRUG, ComboBox.class);
490+
addField(ContactDto.PRESCRIBED_DRUG, ComboBox.class);
491491
region = addInfrastructureField(ContactDto.REGION);
492492
region.setDescription(I18nProperties.getPrefixDescription(ContactDto.I18N_PREFIX, ContactDto.REGION));
493493
district = addInfrastructureField(ContactDto.DISTRICT);
@@ -716,24 +716,24 @@ public String getFormattedHtmlMessage() {
716716
CheckBox prophylaxisPrescribed = addField(ContactDto.PROPHYLAXIS_PRESCRIBED, CheckBox.class);
717717
prophylaxisPrescribed.setCaption(I18nProperties.getCaption(Captions.Contact_prophylaxisPrescribed));
718718

719-
addField(ContactDto.DRUG_TEXT, TextField.class);
719+
addField(ContactDto.PRESCRIBED_DRUG_TEXT, TextField.class);
720720
FieldHelper.setVisibleWhen(
721721
getFieldGroup(),
722-
ContactDto.DRUG,
722+
ContactDto.PRESCRIBED_DRUG,
723723
ContactDto.PROPHYLAXIS_PRESCRIBED,
724724
Collections.singletonList(Boolean.TRUE),
725725
true);
726-
FieldHelper.setRequiredWhenNotNull(getFieldGroup(), ContactDto.PROPHYLAXIS_PRESCRIBED, ContactDto.DRUG);
726+
FieldHelper.setRequiredWhenNotNull(getFieldGroup(), ContactDto.PROPHYLAXIS_PRESCRIBED, ContactDto.PRESCRIBED_DRUG);
727727
FieldHelper.setVisibleWhen(
728728
getFieldGroup(),
729-
ContactDto.DRUG_TEXT,
730-
ContactDto.DRUG,
729+
ContactDto.PRESCRIBED_DRUG_TEXT,
730+
ContactDto.PRESCRIBED_DRUG,
731731
Collections.singletonList(Drug.OTHER),
732732
true);
733733
FieldHelper.setRequiredWhen(
734734
getFieldGroup(),
735-
ContactDto.DRUG,
736-
Arrays.asList(ContactDto.DRUG_TEXT),
735+
ContactDto.PRESCRIBED_DRUG,
736+
Arrays.asList(ContactDto.PRESCRIBED_DRUG_TEXT),
737737
Arrays.asList(Drug.OTHER));
738738
}
739739

0 commit comments

Comments
 (0)