Merge branch 'SciML:master' into fix-ordinarydiffeq-2719

Author: thomvet

.github/workflows/Downgrade.yml

@@ -0,0 +1,36 @@
+name: Downgrade
+on:
+  pull_request:
+    branches:
+      - master
+    paths-ignore:
+      - 'docs/**'
+      - 'benchmark/**'
+  push:
+    branches:
+      - master
+    paths-ignore:
+      - 'docs/**'
+      - 'benchmark/**'
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        downgrade_mode: ['alldeps']
+        julia-version: ['1.10']
+        group: ['Core']
+    steps:
+      - uses: actions/checkout@v4
+      - uses: julia-actions/setup-julia@v2
+        with:
+          version: ${{ matrix.julia-version }}
+      - uses: julia-actions/julia-downgrade-compat@v2
+        with:
+          skip: Pkg,TOML
+      - uses: julia-actions/julia-buildpkg@v1
+      - uses: julia-actions/julia-runtest@v1
+        with:
+          ALLOW_RERESOLVE: false
+        env:
+          GROUP: ${{ matrix.group }}

Project.toml

@@ -1,7 +1,7 @@
 name = "DiffEqBase"
 uuid = "2b5f629d-d688-5b77-993f-72d75c75574e"
 authors = ["Chris Rackauckas <accounts@chrisrackauckas.com>"]
-version = "6.181.0"
+version = "6.183.0"
 
 [deps]
 ArrayInterface = "4fba245c-0d91-5ea0-9b3e-6abc04ee57a9"

src/callbacks.jl

@@ -50,7 +50,7 @@ has_continuous_callback(cb::DiscreteCallback) = false
 has_continuous_callback(cb::ContinuousCallback) = true
 has_continuous_callback(cb::VectorContinuousCallback) = true
 has_continuous_callback(cb::CallbackSet) = !isempty(cb.continuous_callbacks)
-has_continuous_callback(cb::Nothing) = false#======================================================##======================================================#
+has_continuous_callback(cb::Nothing) = false
 
 # Callback handling
 
@@ -478,7 +478,7 @@ function find_callback_time(integrator, callback::VectorContinuousCallback, coun
                 bottom_t = integrator.tprev
             end
             if callback.rootfind != SciMLBase.NoRootFind && !isdiscrete(integrator.alg)
-                min_t = nextfloat(top_t)
+                min_t = isone(integrator.tdir) ? nextfloat(top_t) : prevfloat(top_t)
                 min_event_idx = -1
                 for idx in 1:length(event_idx)
                     if ArrayInterface.allowed_getindex(event_idx, idx) != 0

src/solve.jl

@@ -693,7 +693,7 @@ function step!(integ::NullODEIntegrator, dt = nothing, stop_at_tdt = false)
     if !isnothing(dt)
         integ.t += dt
     else
-        integ.t = integ.sol[end]
+        integ.t = integ.sol.t[end]
     end
     return nothing
 end

test/downstream/null_de.jl

@@ -95,3 +95,10 @@ end
     @test_nowarn SciMLBase.u_modified!(integ, Float64[])
     @test SciMLBase.successful_retcode(SciMLBase.check_error(integ))
 end
+
+@testset "`step!` without dt" begin
+    prob = ODEProblem(Returns(nothing), nothing, (0.0, 1.0))
+    integ = init(prob, Tsit5())
+    @test_nowarn step!(integ)
+    @test integ.t ≈ 1.0
+end

test/gpu/simple_gpu.jl

@@ -1,4 +1,4 @@
-using OrdinaryDiffEq, CUDA, LinearAlgebra, Test, StaticArrays, ADTypes
+using OrdinaryDiffEq, DiffEqBase, CUDA, LinearAlgebra, Test, StaticArrays, ADTypes
 function f(u, p, t)
     A * u
 end