added fallback for constructor for arbitrary factorization inputs

Author: SebastianAment

Project.toml

@@ -1,7 +1,7 @@
 name = "UpdatableCholeskyFactorizations"
 uuid = "1a1c1746-0e7b-45d0-811e-72e8bb59686c"
 authors = ["Sebastian Ament <sebastianeament@gmail.com>"]
-version = "1.1.0"
+version = "1.1.1"
 
 [deps]
 LazyInverses = "9f18896c-49a9-43cc-8eef-c455a8a119c6"

src/cholesky.jl

@@ -42,7 +42,7 @@ function LinearAlgebra.Cholesky(F::UpdatableCholesky)
 end
 
 # converting Cholesky factorization to UpdatableCholesky
-function UpdatableCholeskyFactorizations.updatable_cholesky(C::Union{Cholesky, CholeskyPivoted}, m::Int = size(C, 1); check::Bool = true)
+function updatable_cholesky(C::Union{Cholesky, CholeskyPivoted}, m::Int = size(C, 1); check::Bool = true)
 	U_full = zeros(eltype(C), m, m) # in principle, could do this in place
 	n = size(C, 1)
 	U = C.U
@@ -53,6 +53,12 @@ function UpdatableCholeskyFactorizations.updatable_cholesky(C::Union{Cholesky, C
 	UpdatableCholesky(U_full, n, C.info)
 end
 
+# fall-back for arbitrary factorization object
+function updatable_cholesky(F::Factorization, m::Int = size(F, 1); check::Bool = true)
+	updatable_cholesky(Hermitian(Matrix(F)), m, check = check)
+end
+
+
 function Base.getproperty(F::UpdatableCholesky, s::Symbol)
     if s == :U
         U = @view F.U_full[1:F.n, 1:F.n]

test/cholesky.jl

@@ -49,10 +49,14 @@ using Test
         @test size(C2) == size(C)
 
         # conversion from cholesky type
+        # TODO: test for CholeskyPivoted
         UC2 = updatable_cholesky(C2)
         @test UC2 isa UpdatableCholesky
         @test UC2.U ≈ C2.U
 
+        # testing constructor with arbitrary factorization input
+        @test Matrix(updatable_cholesky(qr(A))) ≈ A
+
         # adding rows and columns
         for i in 1:n
             ai = @view A_full[1:n+i, n+i]