source_residuals: do not filter by runid if not all residuals have a runid attribute

Author: claudiodsf

sourcespec/source_residuals.py

@@ -93,8 +93,20 @@ def _filter_by_runid(residual_dict, runid='latest'):
     """
     if runid is None:
         return residual_dict
+    # Residuals generated by older versions of SourceSpec may not have a runid
+    # attribute. In this case, we cannot filter by runid.
+    if not all(
+        hasattr(spec.stats, 'runid')
+        for spec_st in residual_dict.values()
+        for spec in spec_st
+    ):
+        print(
+            'Warning: not all residuals have a "runid" attribute. '
+            'Filtering by runid will not be applied.'
+        )
+        return residual_dict
     if not isinstance(runid, str):
-        raise ValueError("runid must be a string.")
+        raise ValueError('runid must be a string.')
     filt_residual_dict = defaultdict(SpectrumStream)
     if runid not in ['latest', 'earliest']:
         for spec_st in residual_dict.values():
@@ -166,8 +178,7 @@ def read_residuals(resfiles_dir, runid=None, exclude_subdirs=[]):
         residual_st = read_spectra(resfile)
         for spec in residual_st:
             residual_dict[spec.id].append(spec)
-    #return _filter_by_runid(residual_dict, runid)
-    return residual_dict
+    return _filter_by_runid(residual_dict, runid)
 
 
 def compute_mean_residuals(residual_dict, min_spectra=20):