Refactor DirectBilling and SMS Traits to use string type for serviceId and transactionId parameters

Author: DarkGL

composer.json

@@ -2,7 +2,7 @@
   "name": "simpaypl/simpay",
   "description": "Official SimPay API",
   "type": "library",
-  "version": "2.1.1",
+  "version": "2.2.0",
   "license": "MIT",
   "minimum-stability": "stable",
   "require": {

lib/DirectBilling/Traits/CalculateTrait.php

@@ -7,7 +7,7 @@ trait CalculateTrait
     /**
      * @return mixed
      */
-    public function calculate(int $serviceId, float $amount)
+    public function calculate(string $serviceId, float $amount)
     {
         return $this->guzzle->request('GET', '/directbilling/'.$serviceId.'/calculate', [
             'amount' => $amount,

lib/DirectBilling/Traits/ServicesTrait.php

@@ -18,7 +18,7 @@ public function getServices(int $page = 1, int $limit = 15)
     /**
      * @return mixed
      */
-    public function getService(int $serviceId)
+    public function getService(string $serviceId)
     {
         return $this->guzzle->request('GET', '/directbilling/'.$serviceId);
     }

lib/DirectBilling/Traits/TransactionsTrait.php

@@ -7,7 +7,7 @@ trait TransactionsTrait
     /**
      * @return mixed
      */
-    public function getTransactions(int $serviceId, int $page = 1, int $limit = 15)
+    public function getTransactions(string $serviceId, int $page = 1, int $limit = 15)
     {
         return $this->guzzle->request('GET', '/directbilling/'.$serviceId.'/transactions', [
             'page' => $page,
@@ -18,7 +18,7 @@ public function getTransactions(int $serviceId, int $page = 1, int $limit = 15)
     /**
      * @return mixed
      */
-    public function getTransaction(int $serviceId, string $transactionId)
+    public function getTransaction(string $serviceId, string $transactionId)
     {
         return $this->guzzle->request('GET', '/directbilling/'.$serviceId.'/transactions/'.$transactionId);
     }

lib/Sms/Traits/ServicesTrait.php

@@ -18,15 +18,15 @@ public function getServices(int $page = 1, int $limit = 15)
     /**
      * @return mixed
      */
-    public function getService(int $serviceId)
+    public function getService(string $serviceId)
     {
         return $this->guzzle->request('GET', '/sms/'.$serviceId);
     }
 
     /**
      * @return mixed
      */
-    public function getServiceNumbers(int $serviceId, int $page = 1, int $limit = 15)
+    public function getServiceNumbers(string $serviceId, int $page = 1, int $limit = 15)
     {
         return $this->guzzle->request('GET', '/sms/'.$serviceId.'/numbers', [
             'page' => $page,
@@ -37,15 +37,15 @@ public function getServiceNumbers(int $serviceId, int $page = 1, int $limit = 15
     /**
      * @return mixed
      */
-    public function getServiceNumber(int $serviceId, int $number)
+    public function getServiceNumber(string $serviceId, int $number)
     {
         return $this->guzzle->request('GET', '/sms/'.$serviceId.'/numbers/'.$number);
     }
 
     /**
      * @return mixed
      */
-    public function getSmsCode(int $serviceId, string $code, int $number = null)
+    public function getSmsCode(string $serviceId, string $code, int $number = null)
     {
         return $this->guzzle->request('POST', '/sms/'.$serviceId, [
             'code' => $code,

lib/Sms/Traits/TransactionsTrait.php

@@ -7,7 +7,7 @@ trait TransactionsTrait
     /**
      * @return mixed
      */
-    public function getTransactions(int $serviceId, int $page = 1, int $limit = 15)
+    public function getTransactions(string $serviceId, int $page = 1, int $limit = 15)
     {
         return $this->guzzle->request('GET', '/sms/'.$serviceId.'/transactions', [
             'page' => $page,
@@ -18,7 +18,7 @@ public function getTransactions(int $serviceId, int $page = 1, int $limit = 15)
     /**
      * @return mixed
      */
-    public function getTransaction(int $serviceId, int $transactionId)
+    public function getTransaction(string $serviceId, int $transactionId)
     {
         return $this->guzzle->request('GET', '/sms/'.$serviceId.'/transactions/'.$transactionId);
     }