Mostly why space changes and a comment to clue in future-me of

a "problem" if I happen to notice it again in the future when
working on my test applications.

Author: pspeed42

src/main/java/com/simsilica/ethereal/NetworkStateListener.java

@@ -341,6 +341,19 @@ public void endFrame( long time ) {
                     it.remove();
                     idIndex.retireId(so.getNetworkId());
 
+                    // Dear future-Paul, if you are here because you are trying
+                    // to figure out why a removed object didn't actually get
+                    // removed from the activeIds (and thus not removed on the client)
+                    // note that if there are no other moving objects in the space
+                    // the frame updates stop happening.  There are no frame times
+                    // and so StateCollector stops calling us at all.
+                    // I've left it this way because it is extremely unreastic
+                    // that NO objects would be moving anywhere in the space...
+                    // especially since typically the player itself is an object
+                    // moving in the space.  Fixing it is non-trivial and incurs
+                    // a small overhead all the time just to support this unlikely
+                    // use-case.  But hopefully this comment will save you a couple
+                    // hours of debug logging if you forget why it's like that.  
                     activeIds.remove(so.getEntityId());
                 } else {
                     activeIds.add(so.getEntityId());

src/main/java/com/simsilica/ethereal/zone/StateCollector.java

@@ -208,7 +208,7 @@ protected void publishFrame( StateFrame frame ) {
             }            
             l.beginFrame(frame.getTime());
         }
-            
+
         for( StateBlock b : frame ) {
             publish( b );
         }
@@ -248,7 +248,7 @@ protected void collect() {
         for( StateFrame f : frames ) {
             if( f == null ) {
                 continue;
-            }
+            }            
             publishFrame(f);
         }
 

src/main/java/com/simsilica/ethereal/zone/ZoneManager.java

@@ -231,7 +231,7 @@ public void beginUpdate( long time ) {
         for( Long id : pendingRemoval ) {
             if( log.isDebugEnabled() ) {
                 log.debug("ZONE:  --- delayed deactivation:" + id);
-            }            
+            }
             ZoneRange range = index.remove(id);
             if( log.isDebugEnabled() ) {
                 log.debug("range:" + range);
@@ -439,7 +439,7 @@ public void remove( Long id ) {
         ZoneRange range = index.get(id);
         if( log.isDebugEnabled() ) {
             log.debug("range:" + range);
-        }        
+        }
         if( range == null ) {
             return;
         }

src/main/java/com/simsilica/util/BufferedHashSet.java

@@ -95,6 +95,7 @@ public Set<E> getTransaction() {
      *  Called from the writing thread to apply the buffer changes
      *  to the readable view.
      */
+    @SuppressWarnings("unchecked")
     public void commit() {
         assert checkThread() : badThreadMessage();
         delegate = buffer;