Skip to content

Commit acdfccc

Browse files
committed
feat(api+admin): certification registry manager of a given certification can now delete a competence bloc
1 parent 1e5f5fd commit acdfccc

File tree

4 files changed

+12
-6
lines changed

4 files changed

+12
-6
lines changed

packages/reva-admin-react/src/app/(admin)/certifications-v2/[certificationId]/bloc-competence/[certificationCompetenceBlocId]/updateCompetenceBloc.hook.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,11 @@ const updateCertificationCompetenceBlocMutation = graphql(`
3939

4040
const deleteCertificationCompetenceBlocMutation = graphql(`
4141
mutation deleteCertificationCompetenceBlocForUpdateCompetenceBlocPage(
42-
$certificationCompetenceBlocId: String!
42+
$certificationId: ID!
43+
$certificationCompetenceBlocId: ID!
4344
) {
4445
referential_deleteCertificationCompetenceBloc(
46+
certificationId: $certificationId
4547
certificationCompetenceBlocId: $certificationCompetenceBlocId
4648
) {
4749
id
@@ -92,6 +94,7 @@ export const useUpdateCompetenceBlocPage = ({
9294
const deleteCertificationCompetenceBloc = useMutation({
9395
mutationFn: () =>
9496
graphqlClient.request(deleteCertificationCompetenceBlocMutation, {
97+
certificationId: competenceBloc?.certification.id || "",
9598
certificationCompetenceBlocId,
9699
}),
97100
});

packages/reva-admin-react/src/app/responsable-certifications/certifications/[certificationId]/bloc-competence/[certificationCompetenceBlocId]/updateCompetenceBloc.hook.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,11 @@ const updateCertificationCompetenceBlocMutation = graphql(`
3939

4040
const deleteCertificationCompetenceBlocMutation = graphql(`
4141
mutation deleteCertificationCompetenceBlocForCertificationRegistryManagerUpdateCompetenceBlocPage(
42-
$certificationCompetenceBlocId: String!
42+
$certificationId: ID!
43+
$certificationCompetenceBlocId: ID!
4344
) {
4445
referential_deleteCertificationCompetenceBloc(
46+
certificationId: $certificationId
4547
certificationCompetenceBlocId: $certificationCompetenceBlocId
4648
) {
4749
id
@@ -92,6 +94,7 @@ export const useUpdateCompetenceBlocPage = ({
9294
const deleteCertificationCompetenceBloc = useMutation({
9395
mutationFn: () =>
9496
graphqlClient.request(deleteCertificationCompetenceBlocMutation, {
97+
certificationId: competenceBloc?.certification.id || "",
9598
certificationCompetenceBlocId,
9699
}),
97100
});

packages/reva-api/modules/referential/referential.graphql

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -376,7 +376,8 @@ type Mutation {
376376
input: UpdateCompetenceBlocInput!
377377
): CertificationCompetenceBloc
378378
referential_deleteCertificationCompetenceBloc(
379-
certificationCompetenceBlocId: String!
379+
certificationId: ID!
380+
certificationCompetenceBlocId: ID!
380381
): CertificationCompetenceBloc!
381382
referential_addCertification(input: AddCertificationInput!): Certification!
382383
referential_updateCertificationStructureAndCertificationAuthorities(

packages/reva-api/modules/referential/referential.security.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,8 @@ export const referentialResolversSecurityMap = {
2525
"Mutation.referential_updateCertificationCompetenceBloc":
2626
isAdminOrCertificationRegistryManagerOfCertification,
2727
"Mutation.referential_addCertification": [hasRole(["admin"])],
28-
"Mutation.referential_deleteCertificationCompetenceBloc": [
29-
hasRole(["admin"]),
30-
],
28+
"Mutation.referential_deleteCertificationCompetenceBloc":
29+
isAdminOrCertificationRegistryManagerOfCertification,
3130
"Mutation.referential_updateCertificationStructureAndCertificationAuthorities":
3231
[hasRole(["admin"])],
3332
"Mutation.referential_sendCertificationToRegistryManager": [

0 commit comments

Comments
 (0)