Improve remote worker logs from submissions controller (#1531)

Closes
SoftUni-Internal/exam-systems-issues#1655

Author: gogo4ds

Servers/Worker/OJS.Servers.Worker/Controllers/Api/SubmissionsController.cs

@@ -9,6 +9,7 @@
 using OJS.Services.Infrastructure.Exceptions;
 using OJS.Services.Worker.Business;
 using OJS.Services.Common.Models.Submissions.ExecutionContext;
+using OJS.Services.Infrastructure.Constants;
 using OJS.Services.Infrastructure.Extensions;
 using System;
 using System.Threading.Tasks;
@@ -18,12 +19,18 @@
 public class SubmissionsController : BaseApiController
 {
     private readonly ISubmissionsBusinessService submissionsBusiness;
-    // private readonly ILogger<SubmissionsController> logger;
+    private readonly ILogger<SubmissionsController> logger;
+    private readonly IHostInfoService hostInfoService;
 
     public SubmissionsController(
         ISubmissionsBusinessService submissionsBusiness,
-        ILogger<SubmissionsController> logger) =>
+        ILogger<SubmissionsController> logger,
+        IHostInfoService hostInfoService)
+    {
         this.submissionsBusiness = submissionsBusiness;
+        this.logger = logger;
+        this.hostInfoService = hostInfoService;
+    }
 
     [HttpPost]
     [ProducesResponseType(typeof(FullExecutionResultResponseModel), Status200OK)]
@@ -49,17 +56,6 @@ public async Task<IActionResult> ExecuteFileSubmission(
                 submissionFileRequestModel.WithExceptionStackTrace)
             .ToOkResult();
 
-    // Dont think thats used anymore
-    // [HttpPost]
-    // [ProducesResponseType(typeof(FullExecutionResultResponseModel), Status200OK)]
-    // public async Task<IActionResult> ExecuteFileSubmissionWithJson(
-    //     [ModelBinder(typeof(JsonWithFilesFormDataModelBinder), Name = "executionContextJson")]
-    //     SubmissionFileRequestModel submissionFileRequestModel)
-    //     => await this.ExecuteSubmission(
-    //             submissionFileRequestModel.Map<SubmissionServiceModel>(),
-    //             submissionFileRequestModel.WithExceptionStackTrace)
-    //         .ToOkResult();
-
     private async Task<FullExecutionResultResponseModel> ExecuteSubmission(
         SubmissionServiceModel submission,
         bool withStackTrace)
@@ -74,13 +70,10 @@ private async Task<FullExecutionResultResponseModel> ExecuteSubmission(
 
             result.SetExecutionResult(executionResultResponseModel);
         }
-        catch (BusinessServiceException ex)
-        {
-            result.SetException(ex, false);
-        }
         catch (Exception ex)
         {
-            result.SetException(ex, withStackTrace);
+            this.logger.LogErrorProcessingSubmission(submission.Id, this.hostInfoService.GetHostIp(), ex);
+            result.SetException(ex, ex is not BusinessServiceException && withStackTrace);
         }
         finally
         {