Refactor ParticipantsDataService to remove GetAllByContestWithScoresAndProblems and update related query in ContestResultsBusinessService.

Author: gogo4ds

Services/UI/OJS.Services.Ui.Business/Implementations/ContestResultsBusinessService.cs

@@ -110,7 +110,10 @@ public async Task<ServiceResult<ContestResultsViewModel>> GetContestResults(int
         }
 
         var participants = await this.participantsData
-            .GetAllByContestWithScoresAndProblems(contestId.Value)
+            .GetAllOfficialByContest(contestId.Value)
+            .Include(p => p.Scores)
+            .ThenInclude(s => s.Problem)
+            .ThenInclude(p => p.ProblemGroup)
             .ToListAsync();
 
         var participantResults = participants

Services/UI/OJS.Services.Ui.Data/IParticipantsDataService.cs

@@ -18,8 +18,6 @@ public interface IParticipantsDataService : IDataService<Participant>
 
         IQueryable<Participant> GetAllByUsernameAndContests(string username, IEnumerable<int> contestIds);
 
-        IQueryable<Participant> GetAllByContestWithScoresAndProblems(int contestId);
-
         IQueryable<Participant> GetAllOfficialByContest(int contestId);
 
         Task<bool> ExistsByContestByUserAndIsOfficial(int contestId, string userId, bool isOfficial);

Services/UI/OJS.Services.Ui.Data/Implementations/ParticipantsDataService.cs

@@ -41,12 +41,6 @@ public IQueryable<Participant> GetAllByUsernameAndContests(string username, IEnu
         public IQueryable<Participant> GetAllByContest(int contestId)
             => this.GetQuery(p => p.ContestId == contestId);
 
-        public IQueryable<Participant> GetAllByContestWithScoresAndProblems(int contestId)
-            => this.GetAllByContest(contestId)
-                .Include(p => p.Scores)
-                .ThenInclude(s => s.Problem)
-                .ThenInclude(p => p.ProblemGroup);
-
         public IQueryable<Participant> GetAllOfficialByContest(int contestId)
             => this.GetAllByContest(contestId)
                 .Where(p => p.IsOfficial);