macOS

Author: jrlanglois

modules/squarepine_animation/controllers/squarepine_Timeline.h

@@ -68,9 +68,6 @@ class TimelinePoint final : public Identifiable
 class Timeline final : public Identifiable
 {
 public:
-    /** */
-    Timeline() = default;
-
     /** */
     Timeline (const Identifier& id) noexcept :
         Identifiable (id)

modules/squarepine_animation/particles/squarepine_ParticleSystem.h

@@ -263,12 +263,13 @@ class ParticleEmitter final
 public:
     /** Constructor.
 
+        @param gravityInPxPerUpdate
         @param shouldRemoveParticlesOnEnd
     */
     ParticleEmitter (float gravityInPxPerUpdate = 1.0f,
                      bool shouldRemoveParticlesOnEnd = false) :
-        gravityPxPerUpdate (gravityInPxPerUpdate),
-        shouldRemoveOnEnd (shouldRemoveParticlesOnEnd)
+        shouldRemoveOnEnd (shouldRemoveParticlesOnEnd),
+        gravityPxPerUpdate (gravityInPxPerUpdate)
     {
         jassert (std::isnormal (gravityPxPerUpdate));
     }
@@ -537,4 +538,5 @@ class ParticleSystemComponent : public Component,
     }
 
     JUCE_DECLARE_NON_COPYABLE_WITH_LEAK_DETECTOR (ParticleSystemComponent)
-};
+};
+

modules/squarepine_audio/effects/BitCrusherProcessor.h

@@ -12,7 +12,7 @@ inline FloatType crushSample (FloatType sample, int targetBits)
     const auto x        = std::pow (two, static_cast<FloatType> (targetBits) / dig);
     const auto quant    = x / two;
     const auto dequant  = static_cast<FloatType> (1) / quant;
-    return static_cast<FloatType> (dequant * (int)(sample * quant));
+    return dequant * static_cast<FloatType> (sample * quant);
 }
 
 /** Use this processor to dynamically crush the audio's bits. */

modules/squarepine_cryptography/rng/squarepine_BlumBlumShub.cpp

@@ -3,18 +3,18 @@ namespace bbs
     constexpr std::optional<int> getMSB (const BlumBlumShub::BigM& set)
     {
         for (int i = (int) set.size(); --i >= 0;)
-            if (set.test (i))
+            if (set.test ((size_t) i))
                 return { i };
 
         return std::nullopt;
     }
 
-    BlumBlumShub::BigM toBitset (uint64 value) noexcept
+    inline BlumBlumShub::BigM toBitset (uint64 value) noexcept
     {
         return BlumBlumShub::BigM (static_cast<unsigned long long> (value));
     }
 
-    uint64 fromBitset (const BlumBlumShub::BigM& biggy) noexcept
+    inline uint64 fromBitset (const BlumBlumShub::BigM& biggy) noexcept
     {
         return static_cast<uint64> (biggy.to_ullong());
     }
@@ -39,7 +39,7 @@ namespace bbs
         return gcd (a, b) == 1;
     }
 
-    uint64 createProbablePrime()
+    inline uint64 createProbablePrime()
     {
         const auto biggy = Primes::createProbablePrime (32, 30);
         const auto hsb = biggy.getHighestBit();