Don't run other scheduled things if flow is running

Author: StefanBratanov

src/main/kotlin/com/stefanbratanov/sofiasupermarketsapi/scheduled/ScheduledAlcoholRetriever.kt

@@ -9,11 +9,18 @@ import org.springframework.stereotype.Controller
 
 @Log
 @Controller
-class ScheduledAlcoholRetriever(val alcoholController: AlcoholController) {
+class ScheduledAlcoholRetriever(
+  val alcoholController: AlcoholController,
+  val flowsRunner: ScheduledFlowsRunner,
+) {
 
   @Scheduled(cron = "\${alcohol.retriever.cron}")
   fun retrieveAlcohol() {
     log.info("Scheduled to retrieve alcohol products")
+    if (flowsRunner.isRunning()) {
+      log.info("Skipping because the supermarkets flow is running")
+      return
+    }
     val productCriteria = ProductCriteria(null, false)
     alcoholController.alcohol(productCriteria, null, true)
   }

src/main/kotlin/com/stefanbratanov/sofiasupermarketsapi/scheduled/ScheduledFlowsRunner.kt

@@ -24,4 +24,8 @@ class ScheduledFlowsRunner(val flows: Map<Supermarket, SupermarketFlow>) {
     flows.forEach { (_, flow) -> flow.runSafely() }
     isRunning.set(false)
   }
+
+  fun isRunning(): Boolean {
+    return isRunning.get()
+  }
 }

src/main/kotlin/com/stefanbratanov/sofiasupermarketsapi/scheduled/ScheduledImagesVerifier.kt

@@ -15,12 +15,17 @@ class ScheduledImagesVerifier(
   val googleImageSearch: GoogleImageSearch,
   val cacheManager: CacheManager,
   val productImageRepository: ProductImageRepository,
+  val flowsRunner: ScheduledFlowsRunner,
 ) {
 
   @Scheduled(cron = "\${image.verifier.cron}")
   @Suppress("UNCHECKED_CAST")
   fun verifyImages() {
     log.info("Scheduled to verify images")
+    if (flowsRunner.isRunning()) {
+      log.info("Skipping because the supermarkets flow is running")
+      return
+    }
     val productImagesCache =
       cacheManager.getCache("productImages")?.nativeCache as MutableMap<String?, Any?>?
 

src/test/kotlin/com/stefanbratanov/sofiasupermarketsapi/scheduled/ScheduledAlcoholRetrieverTest.kt

@@ -14,11 +14,13 @@ import org.junit.jupiter.api.extension.ExtendWith
 internal class ScheduledAlcoholRetrieverTest {
 
   @MockK lateinit var alcoholController: AlcoholController
+  @MockK lateinit var flowsRunner: ScheduledFlowsRunner
 
   @InjectMockKs lateinit var scheduledAlcoholRetriever: ScheduledAlcoholRetriever
 
   @Test
   fun `retrieves alcohol`() {
+    every { flowsRunner.isRunning() } returns false
     every { alcoholController.alcohol(any(), any(), any()) } returns emptyList()
 
     scheduledAlcoholRetriever.retrieveAlcohol()

src/test/kotlin/com/stefanbratanov/sofiasupermarketsapi/scheduled/ScheduledImagesVerifierTest.kt

@@ -37,6 +37,8 @@ internal class ScheduledImagesVerifierTest {
 
   @MockkBean lateinit var productImageRepository: ProductImageRepository
 
+  @MockkBean lateinit var flowsRunner: ScheduledFlowsRunner
+
   @Autowired lateinit var underTest: ScheduledImagesVerifier
 
   @Autowired lateinit var cacheManager: CacheManager
@@ -49,6 +51,7 @@ internal class ScheduledImagesVerifierTest {
     cache["test"] = invalidUrl
     cache["another test"] = "https://bbc.co.uk"
 
+    every { flowsRunner.isRunning() } returns false
     every { googleImageSearch.search("test", false) } returns "https://www.telegraph.co.uk/"
     every { productImageRepository.findById("test") } returns
       Optional.of(ProductImage("test", invalidUrl))