Skip to content

Commit 12abe8d

Browse files
committed
Update credits, 3.0
1 parent 650d2b4 commit 12abe8d

File tree

2 files changed

+24
-27
lines changed

2 files changed

+24
-27
lines changed

README.md

Lines changed: 22 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -14,52 +14,51 @@ Please see the [old README](https://github.com/Read-Write/Submariner/blob/a1a10e
1414

1515
## Building
1616

17-
1. Clone recursively (i.e. `git clone --recursive`). Failing that, initialize submodules recursively (`git submodule update --init --recursive`).
17+
1. Clone recursively (i.e. `git clone --recursive`). Failing that, initialize submodules recursively (`git submodule update --init --recursive`). We don't use submodules at the moment, but it's a good idea to in case we do later.
1818
2. Create `Submariner/DEVELOPMENT_TEAM.xcconfig` with contents like `DEVELOPMENT_TEAM = AAAAAAAAAA`, substituting that string with your development ID. If you don't, you'll have a bad day setting up signing.
1919
3. Use Xcode or `xcbuild` to build.
2020

2121
It is recommended you do `git config core.hooksPath .githooks` to avoid commiting your developer ID.
22-
Doing so isn't fatal (it's not a secret), but it is annoying for other contributors.
22+
Doing so isn't fatal (it's not a secret), but it is annoying for other contributors, as Git/Xcode will want you to commit changes to your developer ID, overriding what's in the repository.
2323

24-
## Third-Party
24+
## Third-Party Dependencies
2525

2626
### Vendored
2727

2828
* MGScopeBar by Matt Gemmell
2929
* PXSourceList by Alex Rozanski, Stefan Vogt
30-
* ColumnSplitView by Matt Gallagher
3130

32-
## Release Notes:
31+
## Release Notes
3332

34-
### Version 3.0 (not yet released)
33+
### Version 3.0
3534

3635
* macOS 12 is now the minimum version. macOS 13 or newer is recommended.
37-
* The internal database now stores actual artist and album instead of directory IDs, alleviating many UI quirks when using Subsonic servers
36+
* The internal database now stores actual artist and album instead of directory IDs, alleviating many UI quirks when using Subsonic servers. (GH-73)
3837
* Users of alternative server implementations like Navidrome won't notice anything, as they already use fake directory IDs based on artist and album IDs.
3938
* I've tried hard to make this transition as smooth as possible. Please file an issue if anything goes wrong.
4039
* If reloading and switching away from and back to the server doesn't help, delete recreate your server in the database.
41-
* HTTP requests have been made more async, and shouldn't block the UI.
40+
* HTTP requests have been made more async, and shouldn't block the UI. (GH-175)
4241
* This comes with a major internal simplification to how requests are built, to be more idiomatic Swift.
43-
* Podcasts have been made less buggy
44-
* Adds an inspector sidebar for looking at track properties, now in default toolbar items.
42+
* Adds an inspector sidebar for looking at track properties, now in default toolbar items. (GH-72)
4543
* This shows the selection, and the current playing track otherwise.
4644
* This is now the home of album art; clicking the image will show the full resolution in Quick Look.
47-
* The tracklist now shows the length of the tracklist and count.
45+
* The tracklist now shows the length of the tracklist and count. (GH-112)
4846
* The tracklist toolbar button will show the tracklist if you leave the cursor over the button.
4947
* Adds an option to purge the locally downloaded/cached files. Imported files are unaffected.
5048
* Makes the internal tracklist model index based. Duplicate tracks no longer cause UI wonkiness.
51-
* Reduce the frequency in which the position slider is updated, reducing CPU usage
52-
* Don't update the position slider if the window isn't visible, reducing CPU usage
53-
* Avoid downloading tracks if they're already downloaded
54-
* Remove some images, reduce application size
55-
* Don't show 404 messages to avoid noise w/ ID migrations
56-
* Avoid hitting download endpoint if unneeded
57-
* HTTP timeouts are now handled correctly
58-
* Use remote album artist name when importing downloaded tracks
59-
* Fix tracks unable to be downloaded from Subsonic servers
60-
* Fix a crash when trying to play an album without any tracks
61-
* Fix a crash if the track's duration is nil
62-
* Fix attribute names in schema blocking future refactors.
49+
* Reduce the frequency in which the position slider is updated, reducing CPU usage. (GH-169)
50+
* Don't update the position slider if the window isn't visible, reducing CPU usage. (GH-171)
51+
* Podcast episodes shouldn't duplicate when refreshing.
52+
* Avoid downloading tracks if they're already downloaded.
53+
* Remove some images from the app bundle to reduce application size.
54+
* Use newer split view functionality available in modern macOS.
55+
* Don't show 404 messages to avoid noise w/ database ID migrations.
56+
* HTTP timeouts are now handled correctly, to better handle newer versions of Navidrome. (GH-174)
57+
* Use remote album artist name when importing downloaded tracks.
58+
* Fix tracks unable to be downloaded from Subsonic servers.
59+
* Fix a crash when trying to play an album without any tracks. (GH-166)
60+
* Fix a crash if the track's duration is nil.
61+
* Fix attribute names in schema blocking future refactors. (GH-167)
6362

6463
### Version 2.4.2
6564

Submariner/en.lproj/Credits.rtf

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,7 @@ Janik Baumgartner\kerning1\expnd0\expndtw0 \
2828
Chester Liu\
2929
Jax Wu\
3030
unspezifisch\
31-
\pard\tx560\tx1120\tx1680\tx2240\tx2800\tx3360\tx3920\tx4480\tx5040\tx5600\tx6160\tx6720\partightenfactor0
32-
\cf0 \
31+
\
3332

3433
\f1\b Originally Developed By:
3534
\f0\b0 \
@@ -51,5 +50,4 @@ Janik Baumgartner\kerning1\expnd0\expndtw0 \
5150
\f1\b Using Libraries
5251
\f0\b0 :\
5352
MGScopeBar by Matt Gemmell\
54-
PXSourceList by Alex Rozanski, Stefan Vogt\
55-
ColumnSplitView by Matt Gallagher}
53+
PXSourceList by Alex Rozanski, Stefan Vogt}

0 commit comments

Comments
 (0)