Add tests and improve disconnection handling

- Added `TestingJoiningMultipleTimes` to verify application launch behavior and exception handling in `ComplicatedCasesTester.cs`.
- Renamed constructor parameter from `log` to `logger` in `ConnectionChannel.cs` for clarity.
- Enhanced `OnMessageReceivedAsync` to log debug messages before disconnecting the client.
- Updated `DisconnectAsync` in `ChromeCastClient.cs` to set exceptions for waiting tasks on disconnection.

Author: Tapanila

Sharpcaster.Test/ComplicatedCasesTester.cs

@@ -181,6 +181,25 @@ public async Task TestingWithSwitchingRunningApplication()
             Assert.Equal(0.8, status.Volume.Level.Value, precision: 1);
 
 
+        }
+
+        [Fact]
+        public async Task TestingJoiningMultipleTimes()
+        {
+            var TestHelper = new TestHelper();
+            var client = await TestHelper.CreateConnectAndLoadAppClient(outputHelper, fixture);
+
+
+            //This should cause issues
+            try { 
+                await client.LaunchApplicationAsync("CC1AD845");
+            } catch (Exception ex)
+            {
+                Assert.IsType<TaskCanceledException>(ex);
+                Assert.Contains("Client disconnected before receiving response.", ex.Message);
+            }
+
+
         }
     }
 }

Sharpcaster/Channels/ConnectionChannel.cs

@@ -15,7 +15,7 @@ public class ConnectionChannel : ChromecastChannel
         /// <summary>
         /// Initializes a new instance of ConnectionChannel class
         /// </summary>
-        public ConnectionChannel(ILogger? log = null) : base("tp.connection", log)
+        public ConnectionChannel(ILogger? logger = null) : base("tp.connection", logger)
         {
         }
 
@@ -45,8 +45,8 @@ public async override Task OnMessageReceivedAsync(string messagePayload, string
         {
             if (type == "CLOSE")
             {
-                // In order to avoid usage deadlocks we need to spawn a new Task here!?
-                _ = Task.Run(async () => await Client.DisconnectAsync().ConfigureAwait(false));
+                Logger?.LogDebug("Connection closed by Chromecast, message: {messagePayload}", messagePayload);
+                await Client.DisconnectAsync().ConfigureAwait(false);
             }
             await base.OnMessageReceivedAsync(messagePayload, type).ConfigureAwait(false);
         }

Sharpcaster/ChromeCastClient.cs

@@ -331,6 +331,12 @@ public async Task<string> WaitResponseAsync(int messageRequestId)
 
         public async Task DisconnectAsync()
         {
+            foreach (var task in WaitingTasks)
+            {
+                task.Value?.SetException(new TaskCanceledException("Client disconnected before receiving response."));
+            }
+            WaitingTasks.Clear();
+
             if (HeartbeatChannel != null)
             {
                 HeartbeatChannel.StopTimeoutTimer();