Merge pull request #7939 from guohelu/feat_test_commont_template

fix: 公共流程补充测试用例并修复错误 #7824

Author: dengyh

gcloud/core/apis/drf/serilaziers/common_template.py

@@ -154,6 +154,22 @@ def validate_project_scope(self, value):
             self._validate_scope_changes(value)
         return value
 
+    def validate(self, attrs):
+        pipeline_tree = json.loads(attrs["pipeline_tree"])
+        project_scope = attrs["extra_info"]["project_scope"]
+
+        for activity in pipeline_tree.get("activities").values():
+            if activity.get("type") != "SubProcess" or activity.get("template_source") != "common":
+                continue
+            common_template_id = activity.get("template_id")
+            result = CommonTemplate.objects.get(id=common_template_id)
+            common_project_scope = result.extra_info.get("project_scope")
+            if common_project_scope == ["*"]:
+                continue
+            if not set(project_scope).issubset(set(common_project_scope)):
+                raise serializers.ValidationError(f"保存流程失败，子流程{result.pipeline_template.name}的可见范围与当前流程得可见范围存在冲突")
+        return attrs
+
     class Meta:
         model = CommonTemplate
         fields = [
@@ -183,3 +199,7 @@ class PatchCommonTemplateSerializer(CreateCommonTemplateSerializer):
     class Meta:
         model = CommonTemplate
         fields = ["project_scope"]
+
+    def validate_project_scope(self, value):
+        self._validate_scope_changes(value)
+        return value

gcloud/tests/core/apis/drf/views_set/test_common_template_view.py

@@ -0,0 +1,68 @@
+# -*- coding: utf-8 -*-
+"""
+Tencent is pleased to support the open source community by making 蓝鲸智云PaaS平台社区版 (BlueKing PaaS Community
+Edition) available.
+Copyright (C) 2017-2022 THL A29 Limited, a Tencent company. All rights reserved.
+Licensed under the MIT License (the "License"); you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+http://opensource.org/licenses/MIT
+Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on
+an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the
+specific language governing permissions and limitations under the License.
+"""
+
+import factory
+from django.db.models import signals
+from django_test_toolkit.mixins.account import SuperUserMixin
+from django_test_toolkit.mixins.blueking import LoginExemptMixin, StandardResponseAssertionMixin
+from django_test_toolkit.mixins.drf import DrfPermissionExemptMixin
+from django_test_toolkit.testcases import ToolkitApiTestCase
+from pipeline.models import PipelineTemplate, Snapshot
+
+from gcloud.common_template.models import CommonTemplate
+from unittest.mock import patch
+
+
+class TestCommonTemplateView(
+    ToolkitApiTestCase,
+    SuperUserMixin,
+    LoginExemptMixin,
+    DrfPermissionExemptMixin,
+    StandardResponseAssertionMixin,
+):
+    @factory.django.mute_signals(signals.pre_save, signals.post_save)
+    def setUp(self):
+        super(TestCommonTemplateView, self).setUp()
+        self.test_snapshot = Snapshot.objects.create_snapshot({})
+        self.pipeline_template = PipelineTemplate.objects.create(
+            template_id="template_id", creator="creator", snapshot=self.test_snapshot
+        )
+        self.template_url = "/api/v3/common_template/"
+        self.common_template = CommonTemplate.objects.create(
+            category="category",
+            pipeline_template=self.pipeline_template,
+        )
+        self.mock_referencer_data = [
+            {"template_type": "project", "id": 2, "name": "test_task_template", "project_id": 100},
+        ]
+
+    def test_filter_project_template(self):
+        query_params = {"project_id": 1}
+        response = self.client.get(self.template_url, data=query_params)
+        self.assertTrue(response.data["result"])
+        self.assertIsNotNone(response.data["data"])
+
+    def test_update_common_template(self):
+        self.template_url = "/api/v3/common_template/{}/update_specific_fields/".format(self.common_template.id)
+        query_params = {"project_scope": ["1"]}
+        response = self.client.post(self.template_url, data=query_params, format="json")
+        self.assertTrue(response.data["result"])
+        self.assertIsNotNone(response.data["data"])
+
+    def test_update_common_template_fail(self):
+        with patch.object(CommonTemplate, "referencer", return_value=self.mock_referencer_data) as mock_referencer:
+            self.template_url = "/api/v3/common_template/{}/update_specific_fields/".format(self.common_template.id)
+            query_params = {"project_scope": ["1"]}
+            response = self.client.post(self.template_url, data=query_params, format="json")
+            self.assertFalse(response.data["result"])
+            mock_referencer.assert_called_once()