fix(integration): ensure CPR usability for players during import

Either CPR's "Item Configuration Access" option or
"Item Replacer Access" option needs to be enabled, to allow the
integration to grab the appropriate hook. Without this, the integration
does not work for non-GM users.

As "Item Configuration Access" is the lesser of these two options (it
allows players to e.g. adjust the animations, damage types, etc. of
their CPR items), only require that it be enabled, rather than full
"Item Replacer Access" (which has a greater potential for misuse).

Then, during our CPR-data-fetching step, add a player-only patch to
"enable" the "Item Replacer Access" option, such that we can update our
temp items. In practical terms, this is either done for too short an
interval for the player to notice, or is done while wider activity has
probably locked up the main thread and is preventing any user
interaction anyway, so shouldn't present much opportunity for damage
(intentional or otherwise [the same "intentional" trick could be
pulled much easier with a console one-liner!]).

Author: TheGiddyLimit

module/js/SettingsManager.js

@@ -64,6 +64,8 @@ export class SettingsManager extends StartupHookMixin(class {}) {
 			expectedValue: "showOriginal",
 		},
 		// region chris-premades
+		{moduleId: this._MODULE_ID__CHRIS_PREMADES, isGmOnly: true, settingKey: "Item Configuration Access", displaySettingName: "Item Configuration Access", expectedValue: true},
+
 		{moduleId: this._MODULE_ID__CHRIS_PREMADES, isGmOnly: true, settingKey: "Effect Auras", displaySettingName: "Effect Auras", expectedValue: true},
 		{moduleId: this._MODULE_ID__CHRIS_PREMADES, isGmOnly: true, settingKey: "On Hit", displaySettingName: "On Hit", expectedValue: true},
 		{moduleId: this._MODULE_ID__CHRIS_PREMADES, isGmOnly: true, settingKey: "Combat Listener", displaySettingName: "Combat Listener", expectedValue: true},

module/js/integrations/ChrisPremades.js

@@ -66,13 +66,18 @@ export class IntegrationChrisPremades extends StartupHookMixin(IntegrationBase)
 
 	_stubSemaphores = {};
 
-	async _pWithStubbed (nameStubbed, fn, {returnValue} = {}) {
+	async _pWithStubbed (nameStubbed, {returnValue, fnPatch} = {}, fn) {
 		let out;
 		// Only register/deregister on semaphore 0 to avoid libWrapper errors (a module may only patch a method once)
 		try {
 			this._stubSemaphores[nameStubbed] = this._stubSemaphores[nameStubbed] || 0;
 			if (!this._stubSemaphores[nameStubbed]++) {
-				libWrapper.register(SharedConsts.MODULE_ID, nameStubbed, () => returnValue, _LIBWRAPPER_TYPE_TEMP);
+				libWrapper.register(
+					SharedConsts.MODULE_ID,
+					nameStubbed,
+					(fnOriginal, ...args) => fnPatch ? fnPatch(fnOriginal, ...args) : returnValue,
+					_LIBWRAPPER_TYPE_TEMP,
+				);
 			}
 			out = await fn();
 		} finally {
@@ -135,30 +140,42 @@ export class IntegrationChrisPremades extends StartupHookMixin(IntegrationBase)
 	) {
 		return this._pWithStubbed(
 			"ui.notifications.info",
+			{},
 			() => this._pWithStubbed(
-				"chrisPremades.helpers.dialog",
-				() => this._pWithStubbed(
-					"ChatMessage.create",
-					this._pGetExpandedAddonData_pWithStubbed
-						.bind(
-							this,
-							{
-								propJson,
-								path,
-								fnMatch,
-								ent,
-								propBase,
-								base,
-								actorType,
-								isSilent,
-							},
-						),
-				),
+				"game.settings.get",
 				{
-					returnValue: CONFIG.chrisPremades.itemConfiguration[ent.name]
-						? "update"
-						: true,
+					fnPatch: (fn, ...args) => {
+						const [module, key] = args;
+						if (!game.user.isGM && module === "chris-premades" && key === "Item Replacer Access") return true;
+						return fn(...args);
+					},
 				},
+				() => this._pWithStubbed(
+					"chrisPremades.helpers.dialog",
+					{
+						returnValue: CONFIG.chrisPremades.itemConfiguration[ent.name]
+							? "update"
+							: true,
+					},
+					() => this._pWithStubbed(
+						"ChatMessage.create",
+						{},
+						this._pGetExpandedAddonData_pWithStubbed
+							.bind(
+								this,
+								{
+									propJson,
+									path,
+									fnMatch,
+									ent,
+									propBase,
+									base,
+									actorType,
+									isSilent,
+								},
+							),
+					),
+				),
 			),
 		);
 	}