test: add more tests about automatic fix

Author: ArthurData

R/find_missing_ns.R

@@ -5,8 +5,8 @@ is_ns <- function(text) {
 
 #' @noRd
 is_shiny_input_output_funmodule <- function(
-    text,
-    extend_input_output_funmodule = NA_character_) {
+  text,
+  extend_input_output_funmodule = NA_character_) {
   stopifnot(is.character(extend_input_output_funmodule))
 
   input_output_knew <- c("Input|Output|actionButton|radioButtons")
@@ -55,16 +55,15 @@ fix_ns_in_data <- function(data) {
       substr(line_to_modify, col_end + 1, nchar(line_to_modify))
     )
     file_content[line_index] <- modified_line
+    writeLines(file_content, file)
   }
-
-  writeLines(file_content, file)
 }
 
 #' @noRd
 #' @importFrom utils getParseData
 check_namespace_in_file <- function(
-    path,
-    extend_input_output_funmodule = NA_character_) {
+  path,
+  extend_input_output_funmodule = NA_character_) {
   getParseData(
     parse(
       file = path,
@@ -116,9 +115,9 @@ check_namespace_in_file <- function(
 #'
 #' @export
 check_namespace_sanity <- function(
-    pkg = golem::get_golem_wd(),
-    extend_input_output_funmodule = NA_character_,
-    auto_fix = TRUE) {
+  pkg = golem::get_golem_wd(),
+  extend_input_output_funmodule = NA_character_,
+  auto_fix = TRUE) {
   check_desc_installed()
   check_cli_installed()
 

tests/testthat/test-find_missing_ns.R

@@ -271,6 +271,70 @@ test_that("Check check_namespace_in_file", {
   )
 })
 
+test_that("Check fix_ns_in_data works", {
+  path <- tempfile(fileext = ".R")
+
+  writeLines(
+    c(
+      "mod_test_module_ui <- function(id) {",
+      "  ns <- NS(id)",
+      "  tagList(",
+      "    selectInput(",
+      "      inputId = 'selectinput',", # Missing NS
+      "      label = 'Select input',",
+      "      choices = c(LETTERS[1:10])",
+      "    ),",
+      "    actionButton(",
+      "      inputId = 'actionbutton',", # Missing NS
+      "      label = 'Action button'",
+      "    )",
+      "  )",
+      "}",
+      "",
+      "mod_test_module_server <- function(id) {",
+      "  observeEvent(input$actionbutton, {",
+      "    message(input$actionbutton)",
+      "    message(input$selectinput)",
+      "  })",
+      "}"
+    ),
+    con = path
+  )
+
+  data <- check_namespace_in_file(
+    path = path
+  )
+
+  fix_ns_in_data(data)
+
+  expect_equal(
+    readLines(path),
+    c(
+      "mod_test_module_ui <- function(id) {",
+      "  ns <- NS(id)",
+      "  tagList(",
+      "    selectInput(",
+      "      inputId = ns('selectinput'),", # NS present
+      "      label = 'Select input',",
+      "      choices = c(LETTERS[1:10])",
+      "    ),",
+      "    actionButton(",
+      "      inputId = ns('actionbutton'),", # NS present
+      "      label = 'Action button'",
+      "    )",
+      "  )",
+      "}",
+      "",
+      "mod_test_module_server <- function(id) {",
+      "  observeEvent(input$actionbutton, {",
+      "    message(input$actionbutton)",
+      "    message(input$selectinput)",
+      "  })",
+      "}"
+    )
+  )
+})
+
 dummy_dir_check_ns <- tempfile(pattern = "dummy")
 dir.create(dummy_dir_check_ns)
 
@@ -403,5 +467,47 @@ withr::with_dir(dummy_dir_check_ns, {
       ),
       "NS check passed"
     )
+
+    expect_equal(
+      readLines(file.path(dummy_golem_path, "R", "mod_test_module.R")),
+      c(
+        "#' first UI Function",
+        "#'",
+        "#' @description A shiny Module.",
+        "#'",
+        "#' @param id,input,output,session Internal parameters for {shiny}.",
+        "#'",
+        "#' @shinyModule A Golem module.",
+        "#'",
+        "#' @importFrom shiny NS tagList",
+        "mod_test_module_ui <- function(id) {",
+        "  ns <- NS(id)",
+        "  tagList(",
+        "    selectInput(",
+        "      inputId = ns('selectinput'),",
+        "      label = 'Select input',",
+        "      choices = c(LETTERS[1:10])",
+        "    ),",
+        "    actionButton(",
+        "      inputId = ns('actionbutton'),",
+        "      label = 'Action button'",
+        "    )",
+        "  )",
+        "}",
+        "",
+        "#' first Server Functions",
+        "#'",
+        "mod_test_module_server <- function(id) {",
+        "  moduleServer(id, function(input, output, session) {",
+        "    ns <- session$ns",
+        "",
+        "    observeEvent(input$actionbutton, {",
+        "      message(input$actionbutton)",
+        "      message(input$selectinput)",
+        "    })",
+        "  })",
+        "}"
+      )
+    )
   })
 })