Skip to content
This repository was archived by the owner on Mar 9, 2025. It is now read-only.

Commit 99f06f0

Browse files
committed
clean
1 parent 188b6ef commit 99f06f0

File tree

7 files changed

+56
-62
lines changed

7 files changed

+56
-62
lines changed

build.gradle

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@ version = "$project.mod_version+mc$project.minecraft_version"
88
base.archivesName = project.archives_name
99

1010
loom {
11-
silentMojangMappingsLicense()
12-
1311
accessWidenerPath = file("src/main/resources/fabric-networking-api-v1.accesswidener")
1412
}
1513

@@ -27,10 +25,6 @@ repositories {
2725
// for more information about repositories.
2826
}
2927

30-
loom {
31-
silentMojangMappingsLicense()
32-
}
33-
3428
dependencies {
3529
minecraft "net.minecraft:minecraft:$project.minecraft_version"
3630
mappings(loom.layered {

gradle.properties

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ loom.platform = neoforge
44

55
# Mod properties
66
mod_version = 0.1.0
7-
maven_group = org.thinkingstudio.foxified_networking
7+
maven_group = me.textrue.foxified_networking
88
archives_name = FoxifiedNetworkingAPI
99

1010
# Minecraft properties
@@ -13,4 +13,4 @@ yarn_mappings=1.21.4+build.8
1313
yarn_patch=1.21+build.4
1414

1515
# Dependencies
16-
neoforge_version = 21.4.65-beta
16+
neoforge_version = 21.4.72-beta

src/main/java/org/thinkingstudio/foxified_networking/FoxifiedNetworkingMod.java renamed to src/main/java/me/textrue/foxified_networking/FoxifiedNetworkingMod.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package org.thinkingstudio.foxified_networking;
1+
package me.textrue.foxified_networking;
22

33
import net.fabricmc.fabric.impl.networking.neo.NeoNetworkingImpl;
44
import net.neoforged.bus.api.IEventBus;

src/main/java/net/fabricmc/fabric/impl/networking/client/neo/NeoClientCommonNetworking.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,19 +14,19 @@
1414

1515
public class NeoClientCommonNetworking {
1616
public static void onRegisterPacket(ICommonPacketListener listener, Set<Identifier> ids) {
17-
NetworkPhase protocol = listener.getPhase();
18-
if (protocol == NetworkPhase.CONFIGURATION) {
17+
NetworkPhase phase = listener.getPhase();
18+
if (phase == NetworkPhase.CONFIGURATION) {
1919
listener.getMainThreadEventLoop().execute(() -> C2SConfigurationChannelEvents.REGISTER.invoker().onChannelRegister((ClientConfigurationNetworkHandler) listener, new NeoClientPacketSender(listener.getConnection()), MinecraftClient.getInstance(), List.copyOf(ids)));
20-
} else if (protocol == NetworkPhase.PLAY) {
20+
} else if (phase == NetworkPhase.PLAY) {
2121
listener.getMainThreadEventLoop().execute(() -> C2SPlayChannelEvents.REGISTER.invoker().onChannelRegister((ClientPlayNetworkHandler) listener, new NeoClientPacketSender(listener.getConnection()), MinecraftClient.getInstance(), List.copyOf(ids)));
2222
}
2323
}
2424

2525
public static void onUnregisterPacket(ICommonPacketListener listener, Set<Identifier> ids) {
26-
NetworkPhase protocol = listener.getPhase();
27-
if (protocol == NetworkPhase.CONFIGURATION) {
26+
NetworkPhase phase = listener.getPhase();
27+
if (phase == NetworkPhase.CONFIGURATION) {
2828
listener.getMainThreadEventLoop().execute(() -> C2SConfigurationChannelEvents.UNREGISTER.invoker().onChannelUnregister((ClientConfigurationNetworkHandler) listener, new NeoClientPacketSender(listener.getConnection()), MinecraftClient.getInstance(), List.copyOf(ids)));
29-
} else if (protocol == NetworkPhase.PLAY) {
29+
} else if (phase == NetworkPhase.PLAY) {
3030
listener.getMainThreadEventLoop().execute(() -> C2SPlayChannelEvents.UNREGISTER.invoker().onChannelUnregister((ClientPlayNetworkHandler) listener, new NeoClientPacketSender(listener.getConnection()), MinecraftClient.getInstance(), List.copyOf(ids)));
3131
}
3232
}

src/main/java/net/fabricmc/fabric/impl/networking/neo/NeoNetworkRegistrar.java

Lines changed: 39 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -29,52 +29,52 @@ public class NeoNetworkRegistrar {
2929
throw new UnsupportedOperationException();
3030
});
3131

32-
private final NetworkPhase protocol;
32+
private final NetworkPhase phase;
3333

3434
private final Map<Identifier, NeoPayloadHandler<?>> registeredPayloads = new HashMap<>();
3535

36-
public NeoNetworkRegistrar(NetworkPhase protocol) {
37-
this.protocol = protocol;
36+
public NeoNetworkRegistrar(NetworkPhase phase) {
37+
this.phase = phase;
3838
}
3939

40-
public static boolean hasCodecFor(NetworkPhase protocol, NetworkSide flow, Identifier id) {
41-
PayloadTypeRegistryImpl<? extends PacketByteBuf> registry = getPayloadRegistry(protocol, flow);
40+
public static boolean hasCodecFor(NetworkPhase phase, NetworkSide side, Identifier id) {
41+
PayloadTypeRegistryImpl<? extends PacketByteBuf> registry = getPayloadRegistry(phase, side);
4242
return registry.get(id) != null;
4343
}
4444

45-
public static PayloadTypeRegistryImpl<? extends PacketByteBuf> getPayloadRegistry(NetworkPhase protocol, NetworkSide flow) {
46-
if (protocol == NetworkPhase.PLAY) {
45+
public static PayloadTypeRegistryImpl<? extends PacketByteBuf> getPayloadRegistry(NetworkPhase phase, NetworkSide flow) {
46+
if (phase == NetworkPhase.PLAY) {
4747
return flow == NetworkSide.SERVERBOUND ? PayloadTypeRegistryImpl.PLAY_C2S : PayloadTypeRegistryImpl.PLAY_S2C;
48-
} else if (protocol == NetworkPhase.CONFIGURATION) {
48+
} else if (phase == NetworkPhase.CONFIGURATION) {
4949
return flow == NetworkSide.SERVERBOUND ? PayloadTypeRegistryImpl.CONFIGURATION_C2S : PayloadTypeRegistryImpl.CONFIGURATION_S2C;
5050
} else {
5151
throw new UnsupportedOperationException();
5252
}
5353
}
5454

55-
public <PAYLOAD extends CustomPayload, CONTEXT, HANDLER> boolean registerGlobalReceiver(CustomPayload.Id<PAYLOAD> type, NetworkSide packetFlow, HANDLER handler, Function<IPayloadContext, CONTEXT> ctxFactory, TriConsumer<HANDLER, PAYLOAD, CONTEXT> consumer) {
56-
NeoPayloadHandler<PAYLOAD> neoHandler = getOrRegisterNativeHandler(type);
57-
return neoHandler.registerGlobalHandler(packetFlow, handler, ctxFactory, consumer);
55+
public <P extends CustomPayload, C, H> boolean registerGlobalReceiver(CustomPayload.Id<P> type, NetworkSide side, H handler, Function<IPayloadContext, C> ctxFactory, TriConsumer<H, P, C> consumer) {
56+
NeoPayloadHandler<P> neoHandler = getOrRegisterNativeHandler(type);
57+
return neoHandler.registerGlobalHandler(side, handler, ctxFactory, consumer);
5858
}
5959

60-
public <HANDLER> HANDLER unregisterGlobalReceiver(Identifier id, NetworkSide flow) {
60+
public <H> H unregisterGlobalReceiver(Identifier id, NetworkSide side) {
6161
NeoPayloadHandler<?> neoHandler = registeredPayloads.get(id);
62-
return neoHandler != null ? neoHandler.unregisterGlobalHandler(flow) : null;
62+
return neoHandler != null ? neoHandler.unregisterGlobalHandler(side) : null;
6363
}
6464

65-
public Set<Identifier> getGlobalReceivers(NetworkSide flow) {
65+
public Set<Identifier> getGlobalReceivers(NetworkSide side) {
6666
return registeredPayloads.entrySet().stream()
67-
.filter(e -> e.getValue().hasGlobalHandler(flow))
67+
.filter(e -> e.getValue().hasGlobalHandler(side))
6868
.map(Map.Entry::getKey)
6969
.collect(Collectors.toSet());
7070
}
7171

72-
public <PAYLOAD extends CustomPayload, CONTEXT, HANDLER> boolean registerLocalReceiver(CustomPayload.Id<PAYLOAD> type, ICommonPacketListener listener, HANDLER handler, Function<IPayloadContext, CONTEXT> ctxFactory, TriConsumer<HANDLER, PAYLOAD, CONTEXT> consumer) {
73-
NeoPayloadHandler<PAYLOAD> neoHandler = getOrRegisterNativeHandler(type);
72+
public <P extends CustomPayload, C, H> boolean registerLocalReceiver(CustomPayload.Id<P> type, ICommonPacketListener listener, H handler, Function<IPayloadContext, C> ctxFactory, TriConsumer<H, P, C> consumer) {
73+
NeoPayloadHandler<P> neoHandler = getOrRegisterNativeHandler(type);
7474
return neoHandler.registerLocalReceiver(listener, handler, ctxFactory, consumer);
7575
}
7676

77-
public <HANDLER> HANDLER unregisterLocalReceiver(Identifier id, ICommonPacketListener listener) {
77+
public <H> H unregisterLocalReceiver(Identifier id, ICommonPacketListener listener) {
7878
NeoPayloadHandler<?> neoHandler = registeredPayloads.get(id);
7979
return neoHandler != null ? neoHandler.unregisterLocalHandler(listener) : null;
8080
}
@@ -91,30 +91,30 @@ public Set<Identifier> getLocalSendable(ICommonPacketListener listener) {
9191
if (payloadSetup == null) {
9292
return Set.of();
9393
}
94-
return payloadSetup.channels().get(this.protocol).keySet();
94+
return payloadSetup.channels().get(this.phase).keySet();
9595
}
9696

9797
@SuppressWarnings("unchecked")
98-
private <PAYLOAD extends CustomPayload> NeoPayloadHandler<PAYLOAD> getOrRegisterNativeHandler(CustomPayload.Id<PAYLOAD> type) {
99-
return (NeoPayloadHandler<PAYLOAD>) registeredPayloads.computeIfAbsent(type.id(), k -> {
100-
NeoPayloadHandler<PAYLOAD> handler = new NeoPayloadHandler<>();
98+
private <P extends CustomPayload> NeoPayloadHandler<P> getOrRegisterNativeHandler(CustomPayload.Id<P> type) {
99+
return (NeoPayloadHandler<P>) registeredPayloads.computeIfAbsent(type.id(), k -> {
100+
NeoPayloadHandler<P> handler = new NeoPayloadHandler<>();
101101
boolean setup = NetworkRegistryAccessor.getSetup();
102102

103103
NetworkRegistryAccessor.setSetup(false);
104-
NetworkRegistry.register(type, (PacketCodec<? super PacketByteBuf, PAYLOAD>) DUMMY_CODEC, handler, List.of(protocol), Optional.empty(), "1.0", true);
104+
NetworkRegistry.register(type, (PacketCodec<? super PacketByteBuf, P>) DUMMY_CODEC, handler, List.of(phase), Optional.empty(), "1.0", true);
105105
NetworkRegistryAccessor.setSetup(setup);
106106

107107
// TODO Send registration message when registering late
108108
return handler;
109109
});
110110
}
111111

112-
public static class NeoPayloadHandler<PAYLOAD extends CustomPayload> implements IPayloadHandler<PAYLOAD> {
113-
private final Map<NetworkSide, NeoSubHandler<PAYLOAD, ?, ?>> globalReceivers = new HashMap<>();
114-
private final Map<ICommonPacketListener, NeoSubHandler<PAYLOAD, ?, ?>> localReceivers = new HashMap<>();
112+
public static class NeoPayloadHandler<P extends CustomPayload> implements IPayloadHandler<P> {
113+
private final Map<NetworkSide, NeoSubHandler<P, ?, ?>> globalReceivers = new HashMap<>();
114+
private final Map<ICommonPacketListener, NeoSubHandler<P, ?, ?>> localReceivers = new HashMap<>();
115115

116116
@Override
117-
public void handle(PAYLOAD arg, IPayloadContext context) {
117+
public void handle(P arg, IPayloadContext context) {
118118
NeoSubHandler globalHandler = globalReceivers.get(context.flow());
119119
if (globalHandler != null) {
120120
context.enqueueWork(() -> globalHandler.consumer().accept(globalHandler.handler(), arg, globalHandler.ctxFactory().apply(context)));
@@ -125,13 +125,13 @@ public void handle(PAYLOAD arg, IPayloadContext context) {
125125
}
126126
}
127127

128-
public boolean hasGlobalHandler(NetworkSide flow) {
129-
return globalReceivers.containsKey(flow);
128+
public boolean hasGlobalHandler(NetworkSide side) {
129+
return globalReceivers.containsKey(side);
130130
}
131131

132-
public <CONTEXT, HANDLER> boolean registerGlobalHandler(NetworkSide flow, HANDLER original, Function<IPayloadContext, CONTEXT> ctxFactory, TriConsumer<HANDLER, PAYLOAD, CONTEXT> consumer) {
133-
if (!hasGlobalHandler(flow)) {
134-
globalReceivers.put(flow, new NeoSubHandler<>(original, ctxFactory, consumer));
132+
public <C, H> boolean registerGlobalHandler(NetworkSide side, H original, Function<IPayloadContext, C> ctxFactory, TriConsumer<H, P, C> consumer) {
133+
if (!hasGlobalHandler(side)) {
134+
globalReceivers.put(side, new NeoSubHandler<>(original, ctxFactory, consumer));
135135
return true;
136136
}
137137
return false;
@@ -141,7 +141,7 @@ public boolean hasLocalHandler(ICommonPacketListener listener) {
141141
return localReceivers.containsKey(listener);
142142
}
143143

144-
public <CONTEXT, HANDLER> boolean registerLocalReceiver(ICommonPacketListener listener, HANDLER original, Function<IPayloadContext, CONTEXT> ctxFactory, TriConsumer<HANDLER, PAYLOAD, CONTEXT> consumer) {
144+
public <C, H> boolean registerLocalReceiver(ICommonPacketListener listener, H original, Function<IPayloadContext, C> ctxFactory, TriConsumer<H, P, C> consumer) {
145145
if (!hasLocalHandler(listener)) {
146146
localReceivers.put(listener, new NeoSubHandler<>(original, ctxFactory, consumer));
147147
return true;
@@ -150,17 +150,17 @@ public <CONTEXT, HANDLER> boolean registerLocalReceiver(ICommonPacketListener li
150150
}
151151

152152
@Nullable
153-
public <HANDLER> HANDLER unregisterGlobalHandler(NetworkSide flow) {
154-
NeoSubHandler subHandler = globalReceivers.remove(flow);
155-
return subHandler != null ? (HANDLER) subHandler.handler() : null;
153+
public <H> H unregisterGlobalHandler(NetworkSide side) {
154+
NeoSubHandler subHandler = globalReceivers.remove(side);
155+
return subHandler != null ? (H) subHandler.handler() : null;
156156
}
157157

158158
@Nullable
159-
public <HANDLER> HANDLER unregisterLocalHandler(ICommonPacketListener listener) {
159+
public <H> H unregisterLocalHandler(ICommonPacketListener listener) {
160160
NeoSubHandler subHandler = localReceivers.remove(listener);
161-
return subHandler != null ? (HANDLER) subHandler.handler() : null;
161+
return subHandler != null ? (H) subHandler.handler() : null;
162162
}
163163
}
164164

165-
record NeoSubHandler<PAYLOAD extends CustomPayload, CONTEXT, HANDLER>(HANDLER handler, Function<IPayloadContext, CONTEXT> ctxFactory, TriConsumer<HANDLER, PAYLOAD, CONTEXT> consumer) { }
165+
record NeoSubHandler<P extends CustomPayload, C, H>(H handler, Function<IPayloadContext, C> ctxFactory, TriConsumer<H, P, C> consumer) { }
166166
}

src/main/java/net/fabricmc/fabric/impl/networking/server/neo/NeoServerCommonNetworking.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,25 +15,25 @@
1515

1616
public class NeoServerCommonNetworking {
1717
public static void onRegisterPacket(ICommonPacketListener listener, Set<Identifier> ids) {
18-
NetworkPhase protocol = listener.getPhase();
18+
NetworkPhase phase = listener.getPhase();
1919
MinecraftServer server = ((ServerCommonNetworkHandler) listener).server;
2020
NeoServerPacketSender packetSender = new NeoServerPacketSender(listener.getConnection());
2121

22-
if (protocol == NetworkPhase.CONFIGURATION) {
22+
if (phase == NetworkPhase.CONFIGURATION) {
2323
listener.getMainThreadEventLoop().execute(() -> S2CConfigurationChannelEvents.REGISTER.invoker().onChannelRegister((ServerConfigurationNetworkHandler) listener, packetSender, server, List.copyOf(ids)));
24-
} else if (protocol == NetworkPhase.PLAY) {
24+
} else if (phase == NetworkPhase.PLAY) {
2525
listener.getMainThreadEventLoop().execute(() -> S2CPlayChannelEvents.REGISTER.invoker().onChannelRegister((ServerPlayNetworkHandler) listener, packetSender, server, List.copyOf(ids)));
2626
}
2727
}
2828

2929
public static void onUnregisterPacket(ICommonPacketListener listener, Set<Identifier> ids) {
30-
NetworkPhase protocol = listener.getPhase();
30+
NetworkPhase phase = listener.getPhase();
3131
MinecraftServer server = ((ServerCommonNetworkHandler) listener).server;
3232
NeoServerPacketSender packetSender = new NeoServerPacketSender(listener.getConnection());
3333

34-
if (protocol == NetworkPhase.CONFIGURATION) {
34+
if (phase == NetworkPhase.CONFIGURATION) {
3535
listener.getMainThreadEventLoop().execute(() -> S2CConfigurationChannelEvents.UNREGISTER.invoker().onChannelUnregister((ServerConfigurationNetworkHandler) listener, packetSender, server, List.copyOf(ids)));
36-
} else if (protocol == NetworkPhase.PLAY) {
36+
} else if (phase == NetworkPhase.PLAY) {
3737
listener.getMainThreadEventLoop().execute(() -> S2CPlayChannelEvents.UNREGISTER.invoker().onChannelUnregister((ServerPlayNetworkHandler) listener, packetSender, server, List.copyOf(ids)));
3838
}
3939
}

src/main/resources/META-INF/neoforge.mods.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,14 @@ logoFile = "icon.png"
1616
[[dependencies.foxified_networking]]
1717
modId = "neoforge"
1818
type = "required"
19-
versionRange = "[21.2,)"
19+
versionRange = "[21.3,)"
2020
ordering = "NONE"
2121
side = "BOTH"
2222

2323
[[dependencies.foxified_networking]]
2424
modId = "minecraft"
2525
type = "required"
26-
versionRange = "[1.21,)"
26+
versionRange = "[1.21.3,)"
2727
ordering = "NONE"
2828
side = "BOTH"
2929

0 commit comments

Comments
 (0)