Fix minor issues

Author: TomBursch

.github/workflows/release.yml

@@ -81,7 +81,7 @@ jobs:
             asset_content_type: application/vnd.debian.binary-package
           - os: ubuntu-latest
             container:
-              image: fedora:latest
+              image: fedora:41
               options: --group-add 135
             target: Fedora
             build_target: linux

backend/app/controller/item/item_controller.py

@@ -75,7 +75,7 @@ def searchItemByName(args, household_id):
 @authorize_household()
 @validate_args(AddItem)
 def addItem(args, household_id):
-    name: str = args["name"].strip()
+    name: str = args["name"].strip()[:128]
     if Item.find_by_name(household_id, name):
         raise InvalidUsage()
 
@@ -113,7 +113,7 @@ def updateItem(args, id):
     if "icon" in args:
         item.icon = args["icon"]
     if "name" in args and args["name"] != item.name:
-        newName: str = args["name"].strip()
+        newName: str = args["name"].strip()[:128]
         if not Item.find_by_name(item.household_id, newName):
             item.name = newName
     item.save()

backend/app/jobs/cluster_shoppings.py

@@ -24,7 +24,7 @@ def clusterShoppings(shoppinglist_id: int) -> list | None:
     dbs = DBSCAN1D(eps=eps, min_samples=min_samples)
     labels = dbs.fit_predict(timestamps)
 
-    if not labels:
+    if labels is None or len(labels) == 0:
         app.logger.info("no shopping instances identified")
         return None
 

backend/app/models/item.py

@@ -171,7 +171,7 @@ def create_by_name(
         cls, household_id: int, name: str, default: bool = False
     ) -> Self:
         return cls(
-            name=name.strip(),
+            name=name.strip()[:128],
             default=default,
             household_id=household_id,
         ).save()
@@ -205,13 +205,15 @@ def search_name(cls, name: str, household_id: int) -> list[Self]:
                 cls.query.filter(
                     cls.household_id == household_id,
                     func.levenshtein(
-                        func.lower(func.substring(cls.name, 1, len(name))), name.lower()
+                        func.lower(func.substring(cls.name, 1, len(name))),
+                        name[:128].lower(),
                     )
                     < 4,
                 )
                 .order_by(
                     func.levenshtein(
-                        func.lower(func.substring(cls.name, 1, len(name))), name.lower()
+                        func.lower(func.substring(cls.name, 1, len(name))),
+                        name[:128].lower(),
                     ),
                     cls.support.desc(),
                 )

backend/app/service/recipe_scraping.py

@@ -16,7 +16,16 @@ def scrapePublic(url: str, html: str, household: Household) -> dict[str, Any] |
     except Exception:
         return None
     recipe = Recipe()
-    recipe.name = scraper.title()
+    try:
+        recipe.name = scraper.title()
+    except (
+        NotImplementedError,
+        ValueError,
+        TypeError,
+        AttributeError,
+        SchemaOrgException,
+    ):
+        return None  # Unsupported if title cannot be scraped
     try:
         recipe.time = int(scraper.total_time())
     except (

backend/uv.lock

@@ -24,7 +24,7 @@ class _RecipeListPageState extends State<RecipeListPage> {
     if (!mounted) return 1;
     if (BlocProvider.of<RecipeListCubit>(context).state.listView) return 56;
     return ((headerKey.currentContext!.size!.width - 16 - 32) / getRowCount()) /
-        0.8;
+        0.67;
   }
 
   double getHeaderHeight() {
@@ -35,7 +35,7 @@ class _RecipeListPageState extends State<RecipeListPage> {
     if (!mounted) return 1;
     if (BlocProvider.of<RecipeListCubit>(context).state.listView) return 1;
     // header width - list padding
-    return ((headerKey.currentContext!.size!.width - 16 - 32) / 350).ceil();
+    return ((headerKey.currentContext!.size!.width - 16 - 32) / 328).ceil();
   }
 
   @override
@@ -225,8 +225,8 @@ class _RecipeListPageState extends State<RecipeListPage> {
                                     itemCount: recipes.length,
                                     gridDelegate:
                                         const SliverGridDelegateWithMaxCrossAxisExtent(
-                                      maxCrossAxisExtent: 350,
-                                      childAspectRatio: 0.8,
+                                      maxCrossAxisExtent: 328,
+                                      childAspectRatio: 0.67,
                                     ),
                                     itemBuilder: (context, i) => RecipeCard(
                                       key: Key(recipes[i].name),

kitchenowl/lib/pages/household_page/recipe_list.dart

@@ -113,15 +113,19 @@ class _RecipeCookingPageState extends State<RecipeCookingPage> {
                 ),
                 actions: [
                   IconButton(
-                    onPressed: () => setState(() {
-                      textScaleFactor += 0.1;
-                    }),
+                    onPressed: (textScaleFactor < 4)
+                        ? () => setState(() {
+                              textScaleFactor += 0.1;
+                            })
+                        : null,
                     icon: Icon(Icons.text_increase_rounded),
                   ),
                   IconButton(
-                    onPressed: () => setState(() {
-                      textScaleFactor -= 0.1;
-                    }),
+                    onPressed: (textScaleFactor > 0.8)
+                        ? () => setState(() {
+                              textScaleFactor -= 0.1;
+                            })
+                        : null,
                     icon: Icon(Icons.text_decrease_rounded),
                   ),
                 ],
@@ -157,6 +161,7 @@ class _RecipeCookingPageState extends State<RecipeCookingPage> {
                                   'recipeItem': RecipeItemMarkdownBuilder(
                                       items: widget.recipe.items)
                                 },
+                                textScaler: TextScaler.linear(textScaleFactor),
                                 extensionSet: extensionSet,
                                 imageBuilder: (uri, title, alt) => Image(
                                   fit: BoxFit.cover,

kitchenowl/lib/pages/recipe_cooking_page.dart

@@ -32,6 +32,7 @@ class KitchenOwlMarkdownBuilder extends StatefulWidget {
     this.listItemCrossAxisAlignment =
         MarkdownListItemCrossAxisAlignment.baseline,
     this.softLineBreak = false,
+    this.textScaler,
   });
 
   /// The Markdown to display.
@@ -132,6 +133,8 @@ class KitchenOwlMarkdownBuilder extends StatefulWidget {
   /// specification on soft line breaks when lines of text are joined.
   final bool softLineBreak;
 
+  final TextScaler? textScaler;
+
   @override
   State<KitchenOwlMarkdownBuilder> createState() =>
       _KitchenOwlMarkdownBuilderState();
@@ -180,6 +183,7 @@ class _KitchenOwlMarkdownBuilderState extends State<KitchenOwlMarkdownBuilder>
                   Theme.of(context).cardColor,
               borderRadius: BorderRadius.circular(2.0),
             ),
+            textScaler: widget.textScaler,
           ),
       imageDirectory: widget.imageDirectory,
       imageBuilder: widget.imageBuilder ??