Skip to content

Commit d352fb4

Browse files
🪶 Raii objects need if let Some instead of is_some (#129)
* 🪶 Raii objects need `if let Some` instead of `is_some` * fmt
1 parent ca9589f commit d352fb4

File tree

2 files changed

+34
-40
lines changed

2 files changed

+34
-40
lines changed

src/d3d12/visualizer.rs

Lines changed: 17 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -325,26 +325,23 @@ impl AllocatorVisualizer {
325325
}
326326
}
327327

328-
if ui
329-
.begin_table_header_with_flags(
330-
"alloc_breakdown_table",
331-
[
332-
imgui::TableColumnSetup {
333-
flags: imgui::TableColumnFlags::WIDTH_FIXED,
334-
init_width_or_weight: 50.0,
335-
..imgui::TableColumnSetup::new("Idx")
336-
},
337-
imgui::TableColumnSetup::new("Name"),
338-
imgui::TableColumnSetup {
339-
flags: imgui::TableColumnFlags::WIDTH_FIXED,
340-
init_width_or_weight: 150.0,
341-
..imgui::TableColumnSetup::new("Size")
342-
},
343-
],
344-
imgui::TableFlags::SORTABLE | imgui::TableFlags::RESIZABLE,
345-
)
346-
.is_some()
347-
{
328+
if let Some(_k) = ui.begin_table_header_with_flags(
329+
"alloc_breakdown_table",
330+
[
331+
imgui::TableColumnSetup {
332+
flags: imgui::TableColumnFlags::WIDTH_FIXED,
333+
init_width_or_weight: 50.0,
334+
..imgui::TableColumnSetup::new("Idx")
335+
},
336+
imgui::TableColumnSetup::new("Name"),
337+
imgui::TableColumnSetup {
338+
flags: imgui::TableColumnFlags::WIDTH_FIXED,
339+
init_width_or_weight: 150.0,
340+
..imgui::TableColumnSetup::new("Size")
341+
},
342+
],
343+
imgui::TableFlags::SORTABLE | imgui::TableFlags::RESIZABLE,
344+
) {
348345
let mut allocation_report =
349346
allocation_report.iter().enumerate().collect::<Vec<_>>();
350347

src/vulkan/visualizer.rs

Lines changed: 17 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -338,26 +338,23 @@ impl AllocatorVisualizer {
338338
window.build(ui, || {
339339
ui.input_text("Filter", &mut self.breakdown_filter).build();
340340

341-
if ui
342-
.begin_table_header_with_flags(
343-
"alloc_breakdown_table",
344-
[
345-
imgui::TableColumnSetup {
346-
flags: imgui::TableColumnFlags::WIDTH_FIXED,
347-
init_width_or_weight: 50.0,
348-
..imgui::TableColumnSetup::new("Idx")
349-
},
350-
imgui::TableColumnSetup::new("Name"),
351-
imgui::TableColumnSetup {
352-
flags: imgui::TableColumnFlags::WIDTH_FIXED,
353-
init_width_or_weight: 150.0,
354-
..imgui::TableColumnSetup::new("Size")
355-
},
356-
],
357-
imgui::TableFlags::SORTABLE | imgui::TableFlags::RESIZABLE,
358-
)
359-
.is_some()
360-
{
341+
if let Some(_k) = ui.begin_table_header_with_flags(
342+
"alloc_breakdown_table",
343+
[
344+
imgui::TableColumnSetup {
345+
flags: imgui::TableColumnFlags::WIDTH_FIXED,
346+
init_width_or_weight: 50.0,
347+
..imgui::TableColumnSetup::new("Idx")
348+
},
349+
imgui::TableColumnSetup::new("Name"),
350+
imgui::TableColumnSetup {
351+
flags: imgui::TableColumnFlags::WIDTH_FIXED,
352+
init_width_or_weight: 150.0,
353+
..imgui::TableColumnSetup::new("Size")
354+
},
355+
],
356+
imgui::TableFlags::SORTABLE | imgui::TableFlags::RESIZABLE,
357+
) {
361358
let mut allocation_report =
362359
allocation_report.iter().enumerate().collect::<Vec<_>>();
363360

0 commit comments

Comments
 (0)